Skip to content

Minor Powervs fixes - #3256

Merged
stevenhorsman merged 4 commits into
confidential-containers:mainfrom
Amulyam24:powervs-fixes
Aug 26, 2026
Merged

Minor Powervs fixes#3256
stevenhorsman merged 4 commits into
confidential-containers:mainfrom
Amulyam24:powervs-fixes

Conversation

@Amulyam24

@Amulyam24 Amulyam24 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor
  • Update default systype from s922 to s1022
  • Validate instance type before VM creation
  • Add configurable DHCP timeout
  • Validate required fields in ConfigVerifier

Assisted-by: IBM Bob

@Amulyam24
Amulyam24 requested a review from a team as a code owner August 26, 2026 07:06
Add validation for invalid format of instance types.

Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Allow configuring timeout of IP assignment from DHCP server instead of hard coding it to 750s

Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Update default sys-type to s1022 as s922 is being deprecated across different regions.

Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>

@stevenhorsman stevenhorsman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions/suggestions...

Comment thread src/cloud-providers/ibmcloudpowervs/powervs.go Outdated
Comment thread src/cloud-providers/ibmcloudpowervs/provider.go Outdated
Comment thread src/cloud-providers/ibmcloudpowervs/provider.go Outdated
Add validation for required field - NetworkID, ServiceInstanceID and Zone. Also validate ProcessorType and SystemType against their allowed values.

Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>

@stevenhorsman stevenhorsman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@stevenhorsman
stevenhorsman merged commit 41c6277 into confidential-containers:main Aug 26, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants