config-extractor: verify provider name against registered name in manager - #3235
Open
Amulyam24 wants to merge 3 commits into
Open
config-extractor: verify provider name against registered name in manager#3235Amulyam24 wants to merge 3 commits into
Amulyam24 wants to merge 3 commits into
Conversation
Amulyam24
changed the title
Amulyam24
changed the title
stevenhorsman
left a comment
stevenhorsman
left a comment
Member
There was a problem hiding this comment.
A bug that Bob has suggested and a possible optimisation
Amulyam24
force-pushed
the
verify-provider-name
branch
5 times, most recently
from
August 19, 2026 09:28
1c2080f to
bb0917c
Compare
Amulyam24
force-pushed
the
verify-provider-name
branch
from
August 19, 2026 14:36
bb0917c to
2d75c07
Compare
stevenhorsman
approved these changes
Aug 19, 2026
Amulyam24
force-pushed
the
verify-provider-name
branch
2 times, most recently
from
August 20, 2026 04:55
dd5b204 to
8b8e92d
Compare
chathuryaadapa
approved these changes
Aug 20, 2026
Contributor
Author
|
Hey @stevenhorsman, can this PR be merged? |
Member
Not without second committer's review |
bpradipt
reviewed
Aug 22, 2026
| exit 1 | ||
| } | ||
|
|
||
| # Check for newly generated files that are not yet tracked by git |
Member
There was a problem hiding this comment.
So the expectation is to catch any mismatch with provider name and directory name ?
Contributor
Author
There was a problem hiding this comment.
yes, that correct,
Regenerate the provider yamls to align with the registered provider name - ibmcloud-powervs. Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
The provider name in generated chart files was set from the directory name rather than the name registered at runtime via AddCloudProvider(). Respect the registered name or fall back to the directory name if not found. Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Add a git ls-files --others --exclude-standard check after the existing git diff to catch newly generated files that are not yet tracked. Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
Amulyam24
force-pushed
the
verify-provider-name
branch
from
August 24, 2026 06:02
8b8e92d to
03d9f19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The provider name in generated chart files was set from the directory name. It would be ideal to respect the registered name at runtime via
AddCloudProvider()or fall back to the directory name.