Jf/standardize cpp params#61
Conversation
|
hi @petrasvestartas I guess this is about applying the architecture you developed with foolish consistency |
|
Since multiple files were changed, we need to merge to see if this works locally. |
|
hi @petrasvestartas your right the structure of the commits overlapped with other PR's I'll submit the precise changeset( the last 2 commits) |
- subdivision: pass-by-value → Eigen::Ref<const> - straight_skeleton_2: const& → Eigen::Ref<const> - triangulation: Eigen::Ref → Eigen::Ref<const> - meshing: remove extra & on Eigen::Ref, add const eliminates unnecessary copies, ~240KB+ per call for large datasets
da29e0d to
040eb63
Compare
|
now only the 2 relevant commits |
|
@tomvanmele congrats with the move to |
|
@jf--- can i merge this? |
|
@petrasvestartas perspective is highly relevant here |
|
Thank you. Yes we can merge. P.S. it would be great in mk docs to bring the examples :) |
1 similar comment
|
Thank you. Yes we can merge. P.S. it would be great in mk docs to bring the examples :) |
the examples are already there |
|
was an exciting week; this PR and especially the squeaky fresh mkdocs are a perfect way to wrap up! |
|
Thank you for these cool contributions! |
implementation of #59