Skip to content

swaglog: delete oldest logs on rollover, not newest #38322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adeebshihadeh merged 2 commits into from
Aug 7, 2026
+2 −1
Merged

swaglog: delete oldest logs on rollover, not newest #38322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6281bfc
swaglog: delete oldest logs on rollover, not newest
PeterPhuTran Jul 10, 2026
204e435
Delete openpilot/common/tests/test_swaglog.py
adeebshihadeh Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion openpilot/common/swaglog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ def get_existing_logfiles(self):
fp = os.path.join(base_dir, fn)
if fp.startswith(self.base_filename) and os.path.isfile(fp):
log_files.append(fp)
return sorted(log_files)
# newest first, matching _open()'s insert(0, ...) so doRollover()'s pop() deletes the oldest
return sorted(log_files, reverse=True)

def shouldRollover(self, record):
size_exceeded = self.max_bytes > 0 and self.stream.tell() >= self.max_bytes
Expand Down
Loading