-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(workflows): loop_group node — cross-node subgraph looping #2032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xbeark
wants to merge
14
commits into
coleam00:dev
Choose a base branch
from
xbeark:feat/loop-group-node
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,566
−240
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
08f7e01
feat(workflows): add loop_group node schema + dispatch (stub executor)
137d93e
refactor(workflows): extract runLayers from executeDagWorkflow (T1)
9a0d6b3
feat(workflows): add substituteLoopPrevRefs for cross-iteration refs …
82d7d16
feat(workflows): implement executeLoopGroupNode (T5)
dfe2334
feat(workflows): validate loop_group body as scoped sub-DAG (T3)
bb35b1b
feat(workflows): validator recurses into loop_group body (T8)
b2b9394
docs(workflows): document loop_group cross-node subgraph looping (T10)
8b62f4c
test(workflows): add 4 loop_group instance tests + fix $LOOP_PREV lay…
948d02e
test(workflows): add 10 loop_group edge-case tests
ed464f6
test(workflows): add loop_group tests for interactive/resume, cost, o…
0596f66
fix(workflows): port upstream tier + cold-resume into runLayers after…
7e3b5c6
fix(workflows): address CodeRabbit loop_group review findings
3a58fc0
fix(workflows): loop_group post-body status check + shell-safe $LOOP_…
e2f8d04
fix(workflows): loop_group post-body null handling + $LOOP_USER_INPUT…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Fix
fresh_contextcomment — meaning is inverted.Line 357 says
fresh_context: falsewith the comment "reset body sessions each iteration (default false)". This is backwards:fresh_context: trueresets sessions each iteration;false(the default) preserves context across iterations. Update the comment to:Or if the intent was to show the reset behavior, change the value to
true:📝 Committable suggestion
🤖 Prompt for AI Agents