add missing Bofbool case in Const_eval#6
Open
redianthus wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mlemerre !
We used this operation in Owi with @S41d and noticed it was missing when we started getting runtime assertion failures.
The only difference at runtime is:
I also had to add type annotations because of the polymorphic recursion, otherwise it would complain with:
While adding the type annotations, I realized the big mutual-recursion group was not needed and most functions could be moved out of it. Only the
booleanandbinarycases are mutually recursive. So I went ahead and decided to split the group in small functions, I think this is easier to read like this.Best,