Clean the zip in case a run has not exited properly - #2085
Open
jorbaum wants to merge 1 commit into
Open
Conversation
Previously this raised "file already exists: assets/dora.zip" error
iaftab-alam
approved these changes
Aug 26, 2026
chombium
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this change about?
Previously this raised "file already exists: assets/dora.zip" error
Please provide contextual information.
I am running this test suite locally with cats.sh script of kind-deployment, which basically wraps bin/test of this repository. It happens to me from time to time that CATS tests did not exit properly and a file called
dora.zipprohibited my tests from rerunning due to "file already exists: assets/dora.zip" error.Verified end-to-end against a live cf-on-kind cluster: run the real suite,
SIGKILLit onceassets/dora.zipappears (simulating an interrupted run soAfterSuitenever cleans up), then re-run.Before the fix — the leaked zip breaks the next run:
After the fix — same leaked zip, the re-run cleans it up and proceeds:
No behavior change on a normal run; this only affects re-runs after an interrupted one.
What version of cf-deployment have you run this cf-acceptance-test change against?
Newest head of develop branch.
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
How many more (or fewer) seconds of runtime will this change introduce to CATs?
Less than a second.
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@beyhan @cloudfoundry/wg-app-runtime-platform
🤖 Generated with Claude Code (Opus, claude-opus-latest). Human-reviewed before submitting.