Skip GitBuildpack internet-dependent test on non-OSS stacks - #2063
Merged
davewalter merged 1 commit intoAug 7, 2026
Merged
Conversation
Only run the git-buildpack test when the configured stacks include a known OSS stack (cflinuxfs3, cflinuxfs4, cflinuxfs5), so it doesn't run against proprietary stacks like tanzucflinuxfs1. Skip test if there are no OSS stacks. Passing no -s flag meant the app staged on the platform default stack, which can be a non-OSS stack (e.g. tanzucflinuxfs1) even when an OSS stack is also configured. Explicitly stage on the first OSS stack found in config.Stacks instead.
robdimsdale
force-pushed
the
online-buildpack-oss-stack-only
branch
from
August 7, 2026 19:10
07ba250 to
877009e
Compare
davewalter
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
All PR's to CATs should be submitted to develop and will be merged to main once they've passed acceptance.
What is this change about?
Describe the change and why it's needed.
Only run the git-buildpack test when the configured stacks include a known OSS stack (cflinuxfs3, cflinuxfs4, cflinuxfs5), so it doesn't run against proprietary stacks like tanzucflinuxfs1.
Please provide contextual information.
We have stacks that don't confirm to this pattern but still want to run CATS. The OSS buildpacks won't work on these custom stacks so I want to skip this test for stacks that aren't OSS supported ones
Include any links to other PRs, stories, slack discussions, etc... that will help establish context.
What version of cf-deployment have you run this cf-acceptance-test change against?
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
CATs should validate common operator workflows.
CATs is not a regression test suite.
CATs is run by every component team to validate their releases before promotion.
How many more (or fewer) seconds of runtime will this change introduce to CATs?
0 extra, reduces test runtime by a bit when test is skipped
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.