Fix stale preview URLs - #841
Open
aron-cf wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: f3fd79b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
@ghostwriternr I've added a fix for the reported issue, however I do want to check that this is a bug, rather than the port code acting as intended... |
commit: |
Contributor
📦 Preview BuildVersion: Install the SDK preview:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #829:
exposePort()succeeds but every request to the preview URL returns410 STALE_PREVIEW_URLafter a container restart — even while the container is healthy and serving traffic.Root cause. Preview forwarding is gated on a runtime identity that rotates on every container start:
onStart()callscurrentRuntime.markStarted(), minting a fresh id.exposePort()writes a runtime-scoped activation stamped with the id current at that instant, andonStop()clears activations. Nothing re-derived the activation on start, so after any restart the proxy path sawruntime.owns(activation) === falseand returned stale:Because
exec/containerFetchstarts the container (rotating the id viaonStart), health-checking withexecactively re-invalidated the just-exposed port — which is why re-exposing appeared not to help and staleness persisted for minutes. Durable auth (portTokens) already survives restarts; only the runtime binding was missing.Fix. Re-derive activations from the durable
portTokensfor the new runtime as part ofonStart():This runs only for a container that is already starting, so it never wakes a stopped runtime, and it never resurrects unexposed/destroyed ports (those are absent from
portTokens) — preserving the security intent of #708.