Skip to content

Fix completion crash when item.range starts using {inserting, replacing} #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HighCommander4 merged 2 commits into from
May 7, 2026
+10 −3
Merged

Fix completion crash when item.range starts using {inserting, replacing} #954

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
336471c
Fix completion crash when item.range starts using {inserting, replacing}
argothiel May 4, 2026
f56d5f3
fixup! Fix completion crash when item.range starts using {inserting, …
argothiel May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/clangd-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,17 @@ export class ClangdContext implements vscode.Disposable {
let items = (!list ? [] : Array.isArray(list) ? list : list.items);
items = items.map(item => {
// Gets the prefix used by VSCode when doing fuzzymatch.
let prefix = document.getText(
new vscode.Range((item.range as vscode.Range).start, position))
// item.range is either a Range or {inserting, replacing} (see
// CompletionItem in the VS Code API); narrow before using.
let prefix = '';
if (item.range) {
const start = item.range instanceof vscode.Range
? item.range.start
: item.range.inserting.start;
prefix = document.getText(new vscode.Range(start, position));
}
if (prefix)
item.filterText = prefix + '_' + item.filterText;
item.filterText = prefix + '_' + item.filterText;
// Workaround for https://github.com/clangd/vscode-clangd/issues/357
// clangd's used of commit-characters was well-intentioned, but
// overall UX is poor. Due to vscode-languageclient bugs, we didn't
Expand Down