Add support for bar based guessing#6
Open
xstasi wants to merge 2 commits into
Open
Conversation
Author
|
Hi there! I have made a number of changes to the code in order to fit my use case, which is enhancing midi data with chord information for the purpose of ML data set building. The default behaviour should be unchanged as my changes are all optional, so the code that used autochord before should be unaffected. Feel free to incorporate my changes if you want, otherwise I'll keep using my fork :) completely up to you! Cheers and thanks for starting the project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements my suggestion in Issue #5.
The bar detection is manual but it works for my use case, if necessary the automatic detection can be added later on.