Skip to content

[Snyk] Security upgrade python from 3.11-slim-bookworm to 3.14.0rc3-slim-bookworm - #83

Open
arthrod wants to merge 1 commit into
mainfrom
snyk-fix-f14dd8034593203724306b7e402edd24
Open

[Snyk] Security upgrade python from 3.11-slim-bookworm to 3.14.0rc3-slim-bookworm#83
arthrod wants to merge 1 commit into
mainfrom
snyk-fix-f14dd8034593203724306b7e402edd24

Conversation

@arthrod

@arthrod arthrod commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the dockerfile dependencies of this project.

Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.

Snyk changed the following file(s):

  • Dockerfile

We recommend upgrading to python:3.14.0rc3-slim-bookworm, as this image has only 39 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
critical severity Integer Overflow or Wraparound
SNYK-DEBIAN12-ZLIB-6008963
  500  
high severity Directory Traversal
SNYK-DEBIAN12-PAM-10378969
  400  
high severity Directory Traversal
SNYK-DEBIAN12-PAM-10378969
  400  
high severity Directory Traversal
SNYK-DEBIAN12-PAM-10378969
  400  
high severity Directory Traversal
SNYK-DEBIAN12-PAM-10378969
  400  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Directory Traversal

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai

coderabbitai Bot commented Sep 26, 2025

Copy link
Copy Markdown

Important

Review skipped

Ignore keyword(s) in the title.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch snyk-fix-f14dd8034593203724306b7e402edd24

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @arthrod, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the security of the application by updating its Docker base image. By moving to a newer Python version, the project benefits from critical security fixes, reducing exposure to known vulnerabilities and ensuring a more robust and secure deployment environment.

Highlights

  • Security Upgrade: This pull request upgrades the Python base image in the Dockerfile from "python:3.11-slim-bookworm" to "python:3.14.0rc3-slim-bookworm". This update addresses 2 identified vulnerabilities, specifically an Integer Overflow or Wraparound and multiple instances of Directory Traversal, improving the overall security posture of the application.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, upgrades the Python base image from 3.11-slim-bookworm to 3.14.0rc3-slim-bookworm to address security vulnerabilities. While the intention is good, the proposed change introduces significant risks. Firstly, it uses a release candidate (RC) version of Python, which is not recommended for stability. Secondly, this upgrade will break CUDA support because a related startup script (backend/start.sh) has a hardcoded path to the old Python 3.11 installation. I've added comments with details on these issues.

Comment thread Dockerfile

######## WebUI backend ########
FROM python:3.11-slim-bookworm AS base
FROM python:3.14.0rc3-slim-bookworm AS base

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade to a new Python version breaks existing CUDA functionality. The backend/start.sh script hardcodes the Python version in LD_LIBRARY_PATH to find CUDA libraries:

# backend/start.sh:30
export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/usr/local/lib/python3.11/site-packages/torch/lib:/usr/local/lib/python3.11/site-packages/nvidia/cudnn/lib"

Changing the Python version in this Dockerfile without updating backend/start.sh will cause runtime errors when using CUDA. This change should be coordinated with a fix in backend/start.sh to avoid breaking the application.

Comment thread Dockerfile

######## WebUI backend ########
FROM python:3.11-slim-bookworm AS base
FROM python:3.14.0rc3-slim-bookworm AS base

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using a release candidate version (rc3) of Python introduces a stability risk. Release candidates are not intended for production use and may contain bugs. It is best practice to use a stable release. I suggest using a recent stable version like python:3.13-slim-bookworm instead.

FROM python:3.13-slim-bookworm AS base

@openhands-ai

openhands-ai Bot commented Sep 26, 2025

Copy link
Copy Markdown

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • Integration Test

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #83 at branch `snyk-fix-f14dd8034593203724306b7e402edd24`

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants