[Snyk] Security upgrade python from 3.11-slim-bookworm to 3.14.0rc3-slim-bookworm - #83
[Snyk] Security upgrade python from 3.11-slim-bookworm to 3.14.0rc3-slim-bookworm#83arthrod wants to merge 1 commit into
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-DEBIAN12-ZLIB-6008963 - https://snyk.io/vuln/SNYK-DEBIAN12-PAM-10378969 - https://snyk.io/vuln/SNYK-DEBIAN12-PAM-10378969 - https://snyk.io/vuln/SNYK-DEBIAN12-PAM-10378969 - https://snyk.io/vuln/SNYK-DEBIAN12-PAM-10378969
|
|
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Comment |
Summary of ChangesHello @arthrod, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the security of the application by updating its Docker base image. By moving to a newer Python version, the project benefits from critical security fixes, reducing exposure to known vulnerabilities and ensuring a more robust and secure deployment environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, upgrades the Python base image from 3.11-slim-bookworm to 3.14.0rc3-slim-bookworm to address security vulnerabilities. While the intention is good, the proposed change introduces significant risks. Firstly, it uses a release candidate (RC) version of Python, which is not recommended for stability. Secondly, this upgrade will break CUDA support because a related startup script (backend/start.sh) has a hardcoded path to the old Python 3.11 installation. I've added comments with details on these issues.
|
|
||
| ######## WebUI backend ######## | ||
| FROM python:3.11-slim-bookworm AS base | ||
| FROM python:3.14.0rc3-slim-bookworm AS base |
There was a problem hiding this comment.
This upgrade to a new Python version breaks existing CUDA functionality. The backend/start.sh script hardcodes the Python version in LD_LIBRARY_PATH to find CUDA libraries:
# backend/start.sh:30
export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/usr/local/lib/python3.11/site-packages/torch/lib:/usr/local/lib/python3.11/site-packages/nvidia/cudnn/lib"Changing the Python version in this Dockerfile without updating backend/start.sh will cause runtime errors when using CUDA. This change should be coordinated with a fix in backend/start.sh to avoid breaking the application.
|
|
||
| ######## WebUI backend ######## | ||
| FROM python:3.11-slim-bookworm AS base | ||
| FROM python:3.14.0rc3-slim-bookworm AS base |
There was a problem hiding this comment.
Using a release candidate version (rc3) of Python introduces a stability risk. Release candidates are not intended for production use and may contain bugs. It is best practice to use a stable release. I suggest using a recent stable version like python:3.13-slim-bookworm instead.
FROM python:3.13-slim-bookworm AS base
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
Snyk has created this PR to fix 2 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):
DockerfileWe recommend upgrading to
python:3.14.0rc3-slim-bookworm, as this image has only 39 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.Vulnerabilities that will be fixed with an upgrade:
SNYK-DEBIAN12-ZLIB-6008963
SNYK-DEBIAN12-PAM-10378969
SNYK-DEBIAN12-PAM-10378969
SNYK-DEBIAN12-PAM-10378969
SNYK-DEBIAN12-PAM-10378969
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal