-
Notifications
You must be signed in to change notification settings - Fork 7
Prometheus (range_)query steady-state tolerance verification probes #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sneJ-
wants to merge
14
commits into
chaostoolkit-incubator:master
Choose a base branch
from
sneJ-:feature/DBAAS-977-advanced-query-and-verification-capabilities
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
43231cd
initial step for verification probes
mariadb-JensRowekamp 110d810
DBAAS-977 - initial activities integration
mariadb-JensRowekamp 56b79f8
DBAAS-977 - packaging bugfix
mariadb-JensRowekamp 6782e32
DBAAS-977 - first actual logic for query_results_lower_than_threshold
mariadb-JensRowekamp 3d6ecee
DBAAS-977 - verification probes - iteration
mariadb-JensRowekamp 4f68fa9
DBAAS-977 - bugfix
mariadb-JensRowekamp efe16b7
DBAAS-977 - bugfix
mariadb-JensRowekamp 1588fc6
DBAAS-977 - bugfix
mariadb-JensRowekamp 91aa8e7
DBAAS-977 - further bugfix
mariadb-JensRowekamp 05ae9cc
DBAAS-977 - bugfix
mariadb-JensRowekamp 44a488a
DBAAS-977 - typo
mariadb-JensRowekamp 2b3a61d
DBAAS-977 - bugfix
mariadb-JensRowekamp bbac9ee
DBAAS-977 - changed return from False to ActivityFailed to be evaluat…
mariadb-JensRowekamp 949aa2d
DBAAS-977 - tests added
mariadb-JensRowekamp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,282 @@ | ||
| # -*- coding: utf-8 -*- | ||
| from logzero import logger | ||
| from chaoslib.exceptions import ActivityFailed | ||
| import os | ||
|
|
||
| __all__ = ["query_results_lower_than_threshold", | ||
| "query_results_higher_than_threshold", | ||
| "query_result_degradation"] | ||
|
|
||
| threshold_variable_prefix = "chaosprometheus" | ||
|
|
||
|
|
||
| def query_result_degradation(value: dict, | ||
| threshold_variable: str = None, | ||
| resize: int = 100, | ||
| higher: bool = True) -> bool: | ||
| """ | ||
| On the first run, saves the average of the query result as reference. | ||
| On the second run, compares the average query result against the reference | ||
| to detect performance degradation. | ||
|
|
||
| The parameter `value` will be filled automatically by chaostoolkit and will | ||
| receive the result from Prometheus'es (range_)query. | ||
| The parameter `threshold_variable` defines in what variable the threshold | ||
| will be temporarily stored. | ||
| The parameter `resize` can be used to resize the threshold_variable's | ||
| value to define an upper or lower bound. The resize value defines the | ||
| percentage to which the actual threshold value will be resized. (e.g. | ||
| a value of 100 results in no change, a value 90 results in a decrease of | ||
| 10%, and a value of 110 results in an increase of 10% of the original | ||
| threshold value.) | ||
| If the parameter `higher` is set to `True` the observed value of the 2nd | ||
| run needs to be higher than the reference value. If the parameter `higher` | ||
| is set to `False` the observed value of the 2nd run needs to be below the | ||
| reference value of the 1st run. | ||
| """ | ||
| # second run (compare reference and new value) | ||
| if "%s-%s" % (threshold_variable_prefix, threshold_variable) in globals(): | ||
| if higher: | ||
| return query_results_higher_than_threshold( | ||
| value, | ||
| threshold_variable=threshold_variable) | ||
| else: | ||
| return query_results_lower_than_threshold( | ||
| value, | ||
| threshold_variable=threshold_variable) | ||
| # first run (save the average value as reference) | ||
| else: | ||
| return __set_result_as_threshold_variable(value, threshold_variable, | ||
| resize) | ||
|
|
||
|
|
||
| def query_results_lower_than_threshold(value: dict, | ||
| threshold: float = None, | ||
| threshold_variable: str = None, | ||
| ) -> bool: | ||
| """ | ||
| Checks if all passed Prometheus values are below the | ||
| given threshold. If so returns True, otherwise False. | ||
| If no threshold is given it throws an exception. | ||
| This function can also verify against a saved `threshold_variable`. | ||
| Values from a `threshold_variable` take precedence over `threshold` | ||
| values. | ||
| """ | ||
| if threshold_variable: | ||
| if ("%s-%s" % (threshold_variable_prefix, threshold_variable))\ | ||
| in globals(): | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's not very clean to use globals() that way. |
||
| threshold = globals()[("%s-%s") % (threshold_variable_prefix, | ||
| threshold_variable)] | ||
| logger.debug("Probe: Using threshold %f from global\ | ||
| variable %s-%s" % (threshold, threshold_variable_prefix, threshold_variable)) | ||
|
|
||
| if threshold is None: | ||
| logger.error("Probe: No threshold given") | ||
| raise ActivityFailed() | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good! Though a message in the exception could be useful :) |
||
|
|
||
| rtn = True | ||
|
|
||
| # if no query result is provided exit with False | ||
| if len(value['data']['result']) == 0: | ||
| logger.error("Probe: The query didn't provide any result") | ||
| raise ActivityFailed() | ||
|
|
||
| # check if we got results from a range_query | ||
| range_query = False | ||
| try: | ||
| tmp = value['data']['result'][0]['values'] | ||
| range_query = True | ||
| except Exception: | ||
| pass | ||
|
|
||
| # handle Prometheus range_query | ||
| if range_query: | ||
| for entry in value['data']['result']: | ||
| for value in entry['values']: | ||
| v = __parse_to_number(value[1]) | ||
| if v < threshold: | ||
| logger.debug("Probe: value %f is below the threshold %f" | ||
| % (v, threshold)) | ||
| else: | ||
| logger.error("Probe: value %f is higher than threshold %f" | ||
| % (v, threshold)) | ||
| rtn = False | ||
|
|
||
| # handle Prometheus query | ||
| else: | ||
| for entry in value['data']['result']: | ||
| v = __parse_to_number(entry['value'][1]) | ||
| if v < threshold: | ||
| logger.debug("Probe: value %f is below the threshold %f" % | ||
| (v, threshold)) | ||
| else: | ||
| logger.error("Probe: value %f is higher than threshold %f" % | ||
| (v, threshold)) | ||
| rtn = False | ||
|
|
||
| if rtn: | ||
| logger.info("Probe: ok, all values are below the given threshold\ | ||
| of %f" % (threshold,)) | ||
| else: | ||
| raise ActivityFailed() | ||
|
|
||
| return rtn | ||
|
|
||
|
|
||
| def query_results_higher_than_threshold(value: dict, | ||
| threshold: float = None, | ||
| threshold_variable: str = None, | ||
| ) -> bool: | ||
| """ | ||
| Checks if all passed Prometheus values are higher than the | ||
| given threshold. If so returns True, otherwise False. | ||
| If no threshold is given it throws an exception. | ||
| This function can also verify against a saved `threshold_variable`. | ||
| Values from a `threshold_variable` take precedence over `threshold` | ||
| values. | ||
| """ | ||
| if threshold_variable: | ||
| if "%s-%s" % (threshold_variable_prefix, threshold_variable)\ | ||
| in globals(): | ||
| threshold = globals()[("%s-%s") % (threshold_variable_prefix, | ||
| threshold_variable)] | ||
| logger.debug("Probe: Using threshold %f from global\ | ||
| variable %s-%s" % (threshold, threshold_variable_prefix, threshold_variable)) | ||
|
|
||
| if threshold is None: | ||
| logger.error("Probe: No threshold given") | ||
| raise ActivityFailed() | ||
|
|
||
| rtn = True | ||
|
|
||
| # if no query result is provided exit with False | ||
| if len(value['data']['result']) == 0: | ||
| logger.error("Probe: The query didn't provide any result") | ||
| raise ActivityFailed() | ||
|
|
||
| # check if we got results from a range_query | ||
| range_query = False | ||
| try: | ||
| tmp = value['data']['result'][0]['values'] | ||
| range_query = True | ||
| except Exception: | ||
| pass | ||
|
|
||
| # handle Prometheus range_query | ||
| if range_query: | ||
| for entry in value['data']['result']: | ||
| for value in entry['values']: | ||
| v = __parse_to_number(value[1]) | ||
| if v > threshold: | ||
| logger.debug("Probe: value %f is higher than threshold %f" | ||
| % (v, threshold)) | ||
| else: | ||
| logger.error("Probe: value %f is below the threshold %f" | ||
| % (v, threshold)) | ||
| rtn = False | ||
|
|
||
| # handle Prometheus query | ||
| else: | ||
| for entry in value['data']['result']: | ||
| v = __parse_to_number(entry['value'][1]) | ||
| if v > threshold: | ||
| logger.debug("Probe: value %f is higher than threshold %f" % | ||
| (v, threshold)) | ||
| else: | ||
| logger.error("Probe: value %f is below the threshold %f" % | ||
| (v, threshold)) | ||
| rtn = False | ||
|
|
||
| if rtn: | ||
| logger.info("Probe: ok, all values are higher than the given\ | ||
| threshold %f" % (threshold,)) | ||
| else: | ||
| raise ActivityFailed() | ||
|
|
||
| return rtn | ||
|
|
||
|
|
||
| def __set_result_as_threshold_variable(value: dict, | ||
| threshold_variable: str, | ||
| resize: int = 100, | ||
| ) -> bool: | ||
| """ | ||
| Saves the passed Prometheus query value in an global | ||
| `threshold_variable` that can be used by query_results_ | ||
| functions. Allows to adapt the threshold_variable in % of its own value | ||
| through the `resize` parameter to reduce or increase the threshold value. | ||
|
|
||
| If a `value` is provided from a Prometheus range_query, the average of | ||
| all values will be used as referrence. | ||
|
|
||
| If more than one metric is provided, the average of all metrics will be | ||
| averaged and used as referrence. | ||
|
|
||
| Returns True if it succeeds saving the value in the `threshold_variable`. | ||
| Otherwise, returns False or throws an exception. | ||
| """ | ||
| # if no query result is provided exit with False | ||
| if len(value['data']['result']) == 0: | ||
| logger.error("Probe: The query didn't provide any result") | ||
| raise ActivityFailed() | ||
|
|
||
| # check if we got results from a range_query | ||
| range_query = False | ||
| try: | ||
| tmp = value['data']['result'][0]['values'] | ||
| range_query = True | ||
| except Exception: | ||
| pass | ||
|
|
||
| threshold = float(0.0) | ||
|
|
||
| # extract the average threshold from the Prometheus range_query | ||
| if range_query: | ||
| metrics_thresholds = [] | ||
| try: | ||
| for metric in value['data']['result']: | ||
| threshold = float(0.0) | ||
| for value in metric['values']: | ||
| threshold += __parse_to_number(value[1]) | ||
| metrics_thresholds.append( | ||
| float(threshold / len(metric['values']))) | ||
| threshold = float(0.0) | ||
| for t in metrics_threshold: | ||
| threshold += t | ||
| threshold /= len(metrics_threshold) | ||
| except Exception as e: | ||
| logger.error("Probe: An error occured during the threshold\ | ||
| calculation. %s" % (e,)) | ||
| raise ActivityFailed(e) | ||
|
|
||
| # extract the average threshold value from the Prometheus query | ||
| else: | ||
| try: | ||
| for metric in value['data']['result']: | ||
| threshold += __parse_to_number(metric['value'][1]) | ||
| threshold /= len(value['data']['result']) | ||
| except Exception as e: | ||
| logger.error("Probe: An error occured during the threshold\ | ||
| calculation. %s" % (e,)) | ||
| raise ActivityFailed(e) | ||
|
|
||
| # resize the threshold and save it in an environment variable | ||
| threshold = threshold * float(resize/100) | ||
| globals()["%s-%s" % (threshold_variable_prefix, threshold_variable)] = \ | ||
| threshold | ||
|
|
||
| logger.info("Probe: saved threshold %f in threshold_variable %s" % | ||
| (threshold, threshold_variable)) | ||
|
|
||
| return True | ||
|
|
||
|
|
||
| def __parse_to_number(s: str): | ||
| """ | ||
| Parses given string `s` either into an int or float. | ||
| If it can't parse it, it throws an exception. | ||
| """ | ||
| try: | ||
| return int(s) | ||
| except ValueError: | ||
| return float(s) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For futrure reference, we usually do not change the version in the PR