Rebuild radas_dir on change of radas version or radas config only - #142
Merged
Conversation
Can manually rebuild via workflow dispatch if required.
tbody-cfs
force-pushed
the
reduce_radas_rebuilds
branch
from
June 25, 2026 17:13
ad7a783 to
67c8e4c
Compare
Collaborator
Author
|
Need to add Lint (pre-commit) and Documentation to the required status checks on main |
tbody-cfs
force-pushed
the
reduce_radas_rebuilds
branch
from
June 25, 2026 17:51
ebd896d to
b1bea64
Compare
MishaVeldhoen
approved these changes
Jun 25, 2026
MishaVeldhoen
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - I noticed one issue (that this PR made slightly worse), the linkcheck can fail for reasons unrelated to the PR/build. So requiring it to pass means that a release can be blocked simply because an external server is offline.
Filed a follow-up: #143 to move the linkcheck out of the release CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the CI workflow (
workflow_actions.yml).Radas cache
radas_dircache on the radas version +radas_config.yamlhash rather than the fullpoetry.lock, so unrelated dependency bumps no longer bust the cache and force a regeneration.force_radas_rebuildworkflow_dispatchinput that deletes the cache entry and regenerates from scratch — for when a dependency bump does change radas output and the regression tests fail.Parallel jobs
buildjob into independenttest,lint, anddocsjobs.lint(pre-commit) anddocs(sphinx/doctest/linkcheck) don't need the radas data, so they run in parallel with the tests and surface failures earlier. Release/publish now depend on all three.docsjob, where it's actually used.Note: need to add Lint (pre-commit) and Documentation to the required status checks on main