Skip to content

Rebuild radas_dir on change of radas version or radas config only - #142

Merged
MishaVeldhoen merged 3 commits into
mainfrom
reduce_radas_rebuilds
Jun 25, 2026
Merged

Rebuild radas_dir on change of radas version or radas config only#142
MishaVeldhoen merged 3 commits into
mainfrom
reduce_radas_rebuilds

Conversation

@tbody-cfs

@tbody-cfs tbody-cfs commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Refactors the CI workflow (workflow_actions.yml).

Radas cache

  • Key the radas_dir cache on the radas version + radas_config.yaml hash rather than the full poetry.lock, so unrelated dependency bumps no longer bust the cache and force a regeneration.
  • Added a force_radas_rebuild workflow_dispatch input that deletes the cache entry and regenerates from scratch — for when a dependency bump does change radas output and the regression tests fail.

Parallel jobs

  • Split the monolithic build job into independent test, lint, and docs jobs. lint (pre-commit) and docs (sphinx/doctest/linkcheck) don't need the radas data, so they run in parallel with the tests and surface failures earlier. Release/publish now depend on all three.
  • Moved the pandoc install to the docs job, where it's actually used.

Note: need to add Lint (pre-commit) and Documentation to the required status checks on main

@tbody-cfs
tbody-cfs force-pushed the reduce_radas_rebuilds branch from ad7a783 to 67c8e4c Compare June 25, 2026 17:13
@tbody-cfs

Copy link
Copy Markdown
Collaborator Author

Need to add Lint (pre-commit) and Documentation to the required status checks on main

@tbody-cfs
tbody-cfs force-pushed the reduce_radas_rebuilds branch from ebd896d to b1bea64 Compare June 25, 2026 17:51

@MishaVeldhoen MishaVeldhoen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I noticed one issue (that this PR made slightly worse), the linkcheck can fail for reasons unrelated to the PR/build. So requiring it to pass means that a release can be blocked simply because an external server is offline.

Filed a follow-up: #143 to move the linkcheck out of the release CI.

@MishaVeldhoen
MishaVeldhoen merged commit cc50565 into main Jun 25, 2026
8 checks passed
@MishaVeldhoen
MishaVeldhoen deleted the reduce_radas_rebuilds branch June 25, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants