Skip to content

Wip jcollin testing 20251002.044124 reef - #231

Closed
joscollin wants to merge 179 commits into
wip-reef-dgalloway-nodbgsymfrom
wip-jcollin-testing-20251002.044124-reef
Closed

Wip jcollin testing 20251002.044124 reef#231
joscollin wants to merge 179 commits into
wip-reef-dgalloway-nodbgsymfrom
wip-jcollin-testing-20251002.044124-reef

Conversation

@joscollin

Copy link
Copy Markdown
Member

No description provided.

xiubli and others added 30 commits January 9, 2025 17:33
Set to change the largest ref negotiation request that git will
handle during a fetch. The default value is 10MB and any fetch
requiring a larger buffer will not succeed.

This value should not normally need to be changed, but may be
helpful if you are fetching from a repository with an extremely
large number of refs.

Fixes: https://tracker.ceph.com/issues/66991
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 1d25782)
Fixes: https://tracker.ceph.com/issues/66991
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit b6f8f83)
To explicitly depict what the yaml frag is setting.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit fa46810)
Fixes: https://tracker.ceph.com/issues/68284
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 4a4fc7b)
So that the MDS can transition faster to up:active without
spending much time in processing metrics message during reconnect.

Fixes: http://tracker.ceph.com/issues/68865
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit ba0d989)
Fixes: http://tracker.ceph.com/issues/68855
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit b65d749)
Reject the attempt to rename the CephFS is the CephFS is not offline.
Add new tests for this and update current tests (test_admin.py and
test_volumes.py) accordingly.

Fixes: https://tracker.ceph.com/issues/63154
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit fe3a4b9)

Conflicts:

src/mon/FSCommands.cc
- What is "fsp" in main branch is "fs" in Reef branch due to a missing
  backport.
elsewhere.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
(cherry picked from commit 79a3302)
…t's racy

Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
(cherry picked from commit 11a4303)
…ask is interrupted

Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
(cherry picked from commit eccaf85)

Conflicts:
	qa/tasks/cephfs/test_exports.py
	- conflicts due to additions in main branch
…btree task is interrupted while the state of importer is acking

The related sessions in the importer are in the importing state(`Session::is_importing` return true) when the state of importer is `acking`,
`Migrator::import_reverse` called by `MDCache::handle_resolve` should reverse the process to clear the importing state if the exporter restarts
at this time, but it doesn't do that actually because of its bug. And it will cause these sessions to not be cleared when the client is
unmounted(evicted or timeout) until the mds is restarted.

The bug in `import_reverse` is that it contains the code to handle state `IMPORT_ACKING` but it will never be executed because
the state is modified to `IMPORT_ABORTING` at the beginning. Move `stat.state = IMPORT_ABORTING` to the end of import_reverse
so that it can handle the state `IMPORT_ACKING`.

Fixes: https://tracker.ceph.com/issues/61459
Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
(cherry picked from commit 057c5b1)
…t subtree task is interrupted

Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
(cherry picked from commit f23bd5d)

Conflicts:
	qa/tasks/cephfs/test_exports.py
	- trivial conflict resolved
The importer will force open some sessions provided by the exporter but the client does not know about
the new sessions until the exporter notifies it, and the notifications cannot be sent if the exporter
is interrupted. The client does not renew the sessions regularly that it does not know about, so the client
will be evicted by the importer after `session_autoclose` seconds (300 seconds by default).

The sessions that are forced opened in the importer need to be closed when the import process is reversed.

Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
(cherry picked from commit 00b0711)
Based on the man page of readdir(3), the d_reclen field should contain
the total size of the record, which varies depending on the length of
the returned name. However, the previous implementation was returning a
hardcoded '1' in all cases.

This patch computes the right size of the record and returns it.

Fixes: https://tracker.ceph.com/issues/65389
Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>
(cherry picked from commit 5ac0165)
next_snap is missing from the logs to make sense of the corruption

Fixes: https://tracker.ceph.com/issues/67770
Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 876bdcf)
Fixes: https://tracker.ceph.com/issues/70107
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
(cherry picked from commit 1c0359d)
client_refuse_session must be set for a CephFS before an attempt to
rename a CephFS can be made. Add a new test for this, and update current
tests (test_admin.py and test_volumes.py) accordingly.

Fixes: https://tracker.ceph.com/issues/63154
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 3f93d74)

Conflicts:
src/mon/FSCommands.cc
- What is "fsp" in main branch is "fs" in Reef branch due to a missing
  backport.
…nting clients

Fixes: http://tracker.ceph.com/issues/66088
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 74452ad)
To avoid all sorts for races that could happen when using
sleep().

Signed-off-by: Rishabh Dave <ridave@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 3005495)
If we come across situations where we encounter dangling
symlinks for clones due to any reason,like older versions
may have produced dangling clone symlinks which remained
post-upgrade, it needs to be handled gracefully by deleting
it, presence of which may not allow deletion of the snapshot.
We are now cleaning those up in the snapshot info command.

Fixes: https://tracker.ceph.com/issues/58090
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit efb119e)
Fixes: https://tracker.ceph.com/issues/58090
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit 82d4647)
In following 2 jobs from a Squid QA run we see cluster errors/warnings
which are expected but not added to ignorelist which causes these jobs
to fail.

From https://pulpito.ceph.com/xiubli-2024-07-29_02:08:56-fs-wip-xiubli-testing-20240726.021939-squid-distro-default-smithi/7823678 -

	"2024-07-29T05:10:00.000118+0000 mon.smithi057 (mon.0) 879 : cluster [WRN] Health detail: HEALTH_WARN insufficient standby MDS daemons available" in cluster log

From https://pulpito.ceph.com/xiubli-2024-07-29_02:08:56-fs-wip-xiubli-testing-20240726.021939-squid-distro-default-smithi/7823724 -

	"2024-07-29T06:00:00.000144+0000 mon.smithi104 (mon.0) 600 : cluster [ERR] fs cephfs is degraded" in cluster log

"FS_DEGRADED" and "MDS_INSUFFICIENT_STANDBY" are already present in the
ignorelist for these jobs bit these are not sufficient catch above
cluster warninings/errors. Therefore, add "fs.*is degraded" and
"insufficient standby MDS daemons available" too.

Fixes: https://tracker.ceph.com/issues/67303
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit c30cdbd)

Conflicts:
qa/cephfs/overrides/ignorelist_health.yaml
- A PR that was merged comparatively later in main branch got merged in
  reef branch before this commit/PR. This caused the file in reef to be
  slightly different from its main brach version which caused this
  conflict during application of patch.
Fixes: https://tracker.ceph.com/issues/62077
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
(cherry picked from commit cc7b69f)
Fixes: https://tracker.ceph.com/issues/62077
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
(cherry picked from commit 52ef1f1)
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
(cherry picked from commit 7ce3cea)
Fixes: https://tracker.ceph.com/issues/62077
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
(cherry picked from commit 2128fd0)
Fixes: https://tracker.ceph.com/issues/69274
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit ef84118)
Fixes: https://tracker.ceph.com/issues/69274
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit 814f113)
This cleanup is at the very least incorrect as it can cause the MDS to throw
read-only errors because the data pool is removed before it can write out
backtraces.

We've not yet finalized a truly safe workflow to remove a data pool -- even
flushing the MDS journals first may not be enough (considering a large purge
queue).

Fixes: https://tracker.ceph.com/issues/70919
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
(cherry picked from commit f45cf2d)
rishabh-d-dave and others added 18 commits September 25, 2025 08:43
Added release notes for mgr/vol config option "pause_purging and
"pause_cloning".

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 03b90d5)
reef: mgr/volumes: allow disabling async job threads

Reviewed-by: Jos Collin <jcollin@redhat.com>
Fixes: https://tracker.ceph.com/issues/69878
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit e794a19)
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 058769c)
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 3ae1930)

Conflicts:
qa/tasks/cephfs/test_volumes.py
- Imports on reef branch are slightly different from main leading to
  conflict.
Command "ceph fs volume create" accepts 2 new options to allow users to
pass data and metadata pool name. Update docs to include mention of both
the options.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 3044bf7)
in args.

Add a release note that "ceph fs volume create" command allows users to
pass pool names to "ceph fs volume create" command.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit a74dbbe)
reef: mgr/dashboard: fix zone update API forcing STANDARD storage class

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Fixes: https://tracker.ceph.com/issues/70573
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 0306789)
ll_walk was wrongly coded to make the input file path relative to ino=0. That inode
does not exist and isn't considered the root inode.

Fixes: https://tracker.ceph.com/issues/70573
Fixes: e08210d
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
(cherry picked from commit 25eb99d)

Conflicts:
	src/client/Client.cc: path_walk refactor conflict
Fixes: https://tracker.ceph.com/issues/73290

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit bee24de)

Conflicts:
	monitoring/ceph-mixin/prometheus_alerts.yml
	monitoring/ceph-mixin/tests_alerts/test_alerts.yml
	src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/prometheus/active-alert-list/active-alert-list.component.html
	src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/prometheus/active-alert-list/active-alert-list.component.ts
	src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table-key-value/table-key-value.component.scss
reef: monitoring: fix MTU Mismatch alert rule and expr

Reviewed-by: Afreen Misbah <afreen@ibm.com>
reef: mds: add an asok command to dump export states

Reviewed-by: Jos Collin <jcollin@redhat.com>
* refs/pull/62917/head:
	release note: add a note for "snapshot getpath" command
	doc/cephfs: add doc for "snapshot getpath" cmd
	qa/cephfs: add tests for "subvolume snapshot getpath" cmd
	mgr/vol: add command to get snapshot path
	mgr/vol: move reusable parts from async_cloner
* refs/pull/62500/head:
	client: process path without inode anchor
	test/client: add ll_walk test with cwd and root path
* refs/pull/62460/head:
	PendingReleaseNote: add note that "volume create" accepts pool names...
	doc/cephfs: mention new options for "fs volume create" cmd
	qa/cephfs: test passing pool names to "fs volume create" cmd
	qa/cephfs: separate the tests for "ceph fs volume create" cmd
	mgr/vol: allow passing pool names to "fs volume create" cmd
* refs/pull/62059/head:
	mon,cephfs: small improvement for health warning methods
	qa/cephfs: test that failing a FS is possible when other MDS/FS has...
	qa/cephfs: allow detecting MDS ID from FS object for method the..
	mon,cephfs: don't disallow "fs fail" when other FS/MDS has health...
	cephfs,mon: rename variable to a better name
	mon,cephfs: fix indentation level for a code block
	qa/cephfs: test that a MDS can be failed when other FS/MDS has a...
	qa/cephfs: allow passing MDS ID to method that generate...
	mon,cephfs: check MDS ID before aborting "mds fail" command
* refs/pull/61383/head:
	qa/cephfs: update ignorelist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.