Skip to content
This repository was archived by the owner on Mar 8, 2021. It is now read-only.

Depend on crypto-password, and add support for PBKDF2#137

Closed
zonotope wants to merge 23 commits into
cemerick:masterfrom
zonotope:master
Closed

Depend on crypto-password, and add support for PBKDF2#137
zonotope wants to merge 23 commits into
cemerick:masterfrom
zonotope:master

Conversation

@zonotope

Copy link
Copy Markdown

Fixes #110

@cemerick

Copy link
Copy Markdown
Owner

This looks really great on a quick skim. Could you do a couple things before I really dig in and then merge this though?

  1. Please squash your commits down to a really small number (probably one?)
  2. There are some areas that pop on the diff only because of formatting changes. Could you revert those lines? I don't care that much about formatting, I just want blame to be as useful as possible.

Thanks so much for working on this. Looking forward to merging! :-D

@zonotope

Copy link
Copy Markdown
Author

@cemerick it was easier just to do it all in a different branch. #139 is the new pr.

@zonotope zonotope closed this Mar 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for PBKDF2

2 participants