Skip to content

Fix: show abstract deadline note even when a comment is set - #1552

Merged
mergify[bot] merged 2 commits into
ccfddl:mainfrom
sarendis56:fix_missing_note
Jun 6, 2026
Merged

Fix: show abstract deadline note even when a comment is set#1552
mergify[bot] merged 2 commits into
ccfddl:mainfrom
sarendis56:fix_missing_note

Conversation

@sarendis56

Copy link
Copy Markdown
Contributor

What

Conferences that specify both an abstract_deadline and a comment (e.g. S&P, ICSE, USENIX Security, EuroSys, SIGMOD) were silently dropping the abstract deadline note from the displayed NOTE — only the comment was shown.

Why

The render logic only generated the "abstract deadline on …" note when the
timeline entry had no comment:

if item.comment.is_none() {
    item.comment = Some(format!("abstract deadline on {}.", ...));
}

Demonstration

Before the fix:

The "first paper submission deadline" note takes effect, though there is an abstract deadline, it's not shown.

image

After the fix:

Both are shown, more informative and comply with the intuition.

image

@mergify

mergify Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Welcome to ccf-deadlines!
We're delighted to have you onboard (p≧w≦q)

@mergify mergify Bot added the updateconf update conference deadline label Jun 5, 2026
@mergify
mergify Bot requested a review from a team June 5, 2026 10:09
@mergify
mergify Bot merged commit d03bad4 into ccfddl:main Jun 6, 2026
4 checks passed
@mergify

mergify Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Great job!
Thank you @sarendis56 for your contribution!

@mergify mergify Bot added the ready-to-merge ready to merge the pr label Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge ready to merge the pr updateconf update conference deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants