fix messaging example#105
Draft
DanSchlachter wants to merge 6 commits into
Draft
Conversation
DanSchlachter
commented
May 16, 2025
Contributor
Author
There was a problem hiding this comment.
we add the field.cds, but since it's inside a deep folder structure, it isn't loaded unless referenced e.g. in the services.cds
However, adding it there will lead to issues, as annotations.cds isn't copied to xmpls and breaks the pipeline.
Any idea how to solve this nicely (without having a broken sample or copying the entire annotations file)?
Contributor
There was a problem hiding this comment.
Annotations are already included. We reference it here
https://github.com/cap-js/incidents-app/blob/main/xmpls/messaging/services.cds#L2
Contributor
Author
There was a problem hiding this comment.
but app/services doesn't reference the new file app/incidents/field, so manual adjustment to see the email field was needed before, right?
danjoa
previously approved these changes
May 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.