Oxfmt #438
+39
−3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -136,3 +136,5 @@ dist | |
| test/msg-box | ||
| test/bookshop/gen | ||
| test/bookshop/.cdsrc.json | ||
|
|
||
| .claude/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "$schema": "./node_modules/oxfmt/configuration_schema.json", | ||
| "arrowParens": "avoid", | ||
| "bracketSpacing": true, | ||
| "embeddedLanguageFormatting": "auto", | ||
| "htmlWhitespaceSensitivity": "css", | ||
| "insertPragma": false, | ||
| "jsxSingleQuote": false, | ||
| "printWidth": 120, | ||
| "proseWrap": "preserve", | ||
| "quoteProps": "as-needed", | ||
| "requirePragma": false, | ||
| "semi": false, | ||
| "singleQuote": true, | ||
| "tabWidth": 2, | ||
| "trailingComma": "none", | ||
| "useTabs": false, | ||
| "vueIndentScriptAndStyle": false, | ||
| "sortPackageJson": false, | ||
| "ignorePatterns": [ | ||
| "*.md" | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -119,7 +119,9 @@ class ConsoleMetricExporter extends StandardConsoleMetricExporter { | |
| // export other metrics | ||
| for (const tenant of Object.keys(other)) { | ||
| for (const [k, v] of Object.entries(other[tenant])) { | ||
| LOG.info( | ||
| `${k}${tenant !== 'undefined' ? ` of tenant "${tenant}"` : ''}: ${inspect(v.length === 1 ? v[0] : v)}` | ||
| ) | ||
| } | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,21 +2,26 @@ | |
| "name": "@cap-js/telemetry", | ||
| "version": "1.6.0", | ||
| "description": "CDS plugin providing observability features, incl. automatic OpenTelemetry instrumentation.", | ||
| "homepage": "https://cap.cloud.sap/", | ||
| "license": "Apache-2.0", | ||
| "author": "SAP SE (https://www.sap.com)", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/cap-js/telemetry.git" | ||
| }, | ||
| "files": [ | ||
| "lib" | ||
| ], | ||
| "main": "cds-plugin.js", | ||
| "scripts": { | ||
| "lint": "npx eslint .", | ||
| "fmt": "oxfmt", | ||
| "fmt:check": "oxfmt --check", | ||
| "test": "npx jest --silent" | ||
| }, | ||
| "lint-staged": { | ||
| "*": "oxfmt --no-error-on-unmatched-pattern" | ||
| }, | ||
| "dependencies": { | ||
| "@opentelemetry/api": "^1.9", | ||
| "@opentelemetry/core": "^1.30", | ||
|
|
@@ -28,9 +33,6 @@ | |
| "@opentelemetry/sdk-trace-node": "^1.30", | ||
| "@opentelemetry/semantic-conventions": "^1.36" | ||
| }, | ||
| "devDependencies": { | ||
| "@cap-js/cds-test": "^0", | ||
| "@cap-js/sqlite": "^1 || ^2", | ||
|
|
@@ -48,7 +50,12 @@ | |
| "chai-as-promised": "^7.1.1", | ||
| "chai-subset": "^1.6.0", | ||
| "eslint": "^10", | ||
| "jest": "^29.7.0", | ||
| "lint-staged": "^17.0.8", | ||
| "oxfmt": "^0.56.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "@sap/cds": "^8 || ^9" | ||
|
Contributor
There was a problem hiding this comment. Bug: Please provide feedback on the review comment by checking the appropriate box:
|
||
| }, | ||
| "cds": { | ||
| "requires": { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best Practice: File is missing a trailing newline (
\ No newline at end of file) - most linters and editors expect a newline at end of file, and it's inconsistent with the formatter's own intent.Please provide feedback on the review comment by checking the appropriate box: