fix: wrong hana single tenant credential connection loop#1680
Open
kasimos wants to merge 1 commit into
Open
Conversation
Comment on lines
+62
to
67
| if (err.code === 10) { | ||
| // authentication error | ||
| LOG.debug('connection failed:', err) | ||
| throw new Error(`Pool failed connecting`, { cause: err }) | ||
| } | ||
| if (attempt < maxRetries) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (err.code === 10) { | |
| // authentication error | |
| LOG.debug('connection failed:', err) | |
| throw new Error(`Pool failed connecting`, { cause: err }) | |
| } | |
| if (attempt < maxRetries) { | |
| if (err.code !== 10 && attempt < maxRetries) { |
I think the error just needs to bubble up. There's no need to log or wrap it.
Author
There was a problem hiding this comment.
This works except for the initial connection when starting a CAP app. There the proposed change will throw:
"[queue] - Failed to fetch targets for flush Error: Pool resource could not be acquired within 10s"
For requests that are after that hitting the service it will correctly show: "[odata] - 500 - SqlError {message: "authentication failed..."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Ticket #1679
Now auth errors in single tenant hana connections will be logged in the debug log and throw an appropriate error, thereby no longer running into a loop and locking the db user