Skip to content

Document decoded route literals#423

Merged
yawaramin merged 1 commit into
camlworks:masterfrom
funwithcthulhu:temp/document-decoded-routes
May 23, 2026
Merged

Document decoded route literals#423
yawaramin merged 1 commit into
camlworks:masterfrom
funwithcthulhu:temp/document-decoded-routes

Conversation

@funwithcthulhu

Copy link
Copy Markdown
Contributor

Summary

  • Document that route path literals are matched against decoded request paths.
  • Add an expect test showing a percent-encoded request target matches the decoded route literal, while Dream.target and logger output can still preserve the original encoded target.

Closes #414.

Validation

  • git diff --check upstream/master...HEAD
  • opam exec -- dune runtest test/expect/server (fails locally because this switch is missing ppx_expect.config_types, ppx_expect, and lwt_ppx)

@yawaramin yawaramin marked this pull request as ready for review May 23, 2026 18:26
@yawaramin yawaramin merged commit 2ce65e1 into camlworks:master May 23, 2026
6 of 7 checks passed
@funwithcthulhu funwithcthulhu deleted the temp/document-decoded-routes branch May 24, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

URL handling for escaped characters inconsistent between routes and requests

2 participants