Add post_connect to sql_pool #422
Merged
Merged
Conversation
Allow for a custom post_connect to run for new SQL connection, for example registering user functions for SQLite connections.
yawaramin
approved these changes
May 11, 2026
Contributor
Author
|
Thanks @yawaramin , any chance to merge this PR, and what are the plans for a next release? |
Member
|
No prob. I am good to merge this PR next week if no objections. I've set a reminder for myself. Regarding a new release–yes we do need a cut a new release because it's been some time. Need to discuss this a bit to decide when exactly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is taking over #377, which looks stale. I've addressed @yawaramin 's comments and changed the logic so Dream's standard post_connect is not called when a user-defined one is provided.
Closes: #377