chore: fix bugs, cleanup dead code, add CI and firefox user.js#425
Open
simply-sharat wants to merge 1 commit into
Open
chore: fix bugs, cleanup dead code, add CI and firefox user.js#425simply-sharat wants to merge 1 commit into
simply-sharat wants to merge 1 commit into
Conversation
simply-sharat
commented
Jun 1, 2026
- hypr/scripts/wsaction.fish: fix incorrect set -e $argv[1] syntax
- hypr/scripts/configs.fish: fix if _reload using var as command
- starship.toml: fix typo 'ellow' -> 'yellow'
- zen/userChrome.css: remove ~90 lines of commented-out dead code
- README.md: fix install.sh reference to install.fish
- hypr/hyprland/rules.conf: clean up messy comment
- PKGBUILD: add missing ydotool dependency
- install.fish: remove deprecated yay -Y flags, fix help text
- vscode/settings.json: remove wildcard from codeium config for privacy
- firefox: add user.js with privacy/security/performance tweaks
- .github: add CI workflow with fish syntax check and CSS lint
- hypr/env.conf + uwsm/env-hyprland: add sync comments for duplicated vars
- hypr/scripts/wsaction.fish: fix incorrect set -e $argv[1] syntax - hypr/scripts/configs.fish: fix if _reload using var as command - starship.toml: fix typo 'ellow' -> 'yellow' - zen/userChrome.css: remove ~90 lines of commented-out dead code - README.md: fix install.sh reference to install.fish - hypr/hyprland/rules.conf: clean up messy comment - PKGBUILD: add missing ydotool dependency - install.fish: remove deprecated yay -Y flags, fix help text - vscode/settings.json: remove wildcard from codeium config for privacy - firefox: add user.js with privacy/security/performance tweaks - .github: add CI workflow with fish syntax check and CSS lint - hypr/env.conf + uwsm/env-hyprland: add sync comments for duplicated vars
simply-sharat
commented
Jun 1, 2026
simply-sharat
left a comment
Author
There was a problem hiding this comment.
- hypr/scripts/wsaction.fish: fix
set -e $argv[1]→set -e argv[1] - hypr/scripts/configs.fish: fix
if _reload→if $_reload - starship.toml: fix typo
ellow→yellow - zen/userChrome.css: remove ~90 lines of commented-out dead code
- README.md: fix
install.sh→install.fishin help output - hypr/hyprland/rules.conf: clean up messy comment
- PKGBUILD: add missing
ydotooldependency - install.fish: remove deprecated
yay -Yflags, fix help text - vscode/settings.json: remove wildcard from
codeium.enableConfig - firefox: add
user.jswith privacy/security/performance tweaks - .github: add CI workflow with fish syntax check and CSS lint
- hypr/env.conf + uwsm/env-hyprland: add sync comments for duplicated vars
|
Some of these feel more opinionated than just chores. Things like Firefox configurations for changing suggestions, disabling formfill, enabling media hardware acceleration, etc. are just assuming every user that's currently using these dots wants those changes. While I understand changes for privacy and security are beneficial, this seems to border on going out of scope. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.