Skip to content

UI certificate fetch fails with PermissionError on ACME account private keys #3253 #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkf-sysangels wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

UI certificate fetch fails with PermissionError on ACME account private keys #3253 #3290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/common/core/letsencrypt/ui/blueprints/letsencrypt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,22 @@ def download_certificates():

cache_files = DB.get_jobs_cache_files(job_name="certbot-renew")

_ALLOWED_PREFIXES = ("live/", "archive/", "renewal/", "./live/", "./archive/", "./renewal/")

def _cert_members(tar):
for member in tar.getmembers():
# Only extract the three subdirectories the UI needs; skip accounts/ and
# anything else (e.g. ACME private keys with mode 0600 owned by root).
if any(member.name.startswith(prefix) for prefix in _ALLOWED_PREFIXES):
yield member

for cache_file in cache_files:
if cache_file["file_name"].endswith(".tgz") and cache_file["file_name"].startswith("folder:"):
with tar_open(fileobj=BytesIO(cache_file["data"]), mode="r:gz") as tar:
try:
tar.extractall(DATA_PATH, filter="fully_trusted")
tar.extractall(DATA_PATH, members=_cert_members(tar), filter="fully_trusted")
except TypeError:
tar.extractall(DATA_PATH)
tar.extractall(DATA_PATH, members=_cert_members(tar))


def retrieve_certificates():
Expand Down