Skip to content

UI certificate parser fails with MalformedFraming on fullchain.pem #3289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkf-sysangels wants to merge 1 commit into
base: dev
Choose a base branch
from
+18 −2
Open

UI certificate parser fails with MalformedFraming on fullchain.pem #3289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/common/core/letsencrypt/ui/actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,15 @@ def retrieve_certificates_info(folder_paths: Tuple[Path, Path]) -> dict:

# * Parsing the certificate
try:
cert = x509.load_pem_x509_certificate(cert_file.read_bytes(), default_backend())
pem_data = cert_file.read_bytes()
# fullchain.pem contains the leaf cert followed by one or more intermediates.
# load_pem_x509_certificate only accepts a single block; strip everything
# after the first END marker so newer cryptography versions don't raise MalformedFraming.
_end_marker = b"-----END CERTIFICATE-----"
_first_end = pem_data.find(_end_marker)
if _first_end != -1:
pem_data = pem_data[: _first_end + len(_end_marker)]
cert = x509.load_pem_x509_certificate(pem_data, default_backend())

# ? Getting the subject
subject = cert.subject.get_attributes_for_oid(x509.NameOID.COMMON_NAME)
Expand Down
10 changes: 9 additions & 1 deletion src/common/core/letsencrypt/ui/blueprints/letsencrypt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,15 @@ def retrieve_certificates():
"key_type": "Unknown",
}
try:
cert = x509.load_pem_x509_certificate(cert_file.read_bytes(), default_backend())
pem_data = cert_file.read_bytes()
# fullchain.pem contains the leaf cert followed by one or more intermediates.
# load_pem_x509_certificate only accepts a single block; strip everything
# after the first END marker so newer cryptography versions don't raise MalformedFraming.
_end_marker = b"-----END CERTIFICATE-----"
_first_end = pem_data.find(_end_marker)
if _first_end != -1:
pem_data = pem_data[: _first_end + len(_end_marker)]
cert = x509.load_pem_x509_certificate(pem_data, default_backend())
subject = cert.subject.get_attributes_for_oid(x509.NameOID.COMMON_NAME)
if subject:
cert_info["common_name"] = subject[0].value
Expand Down