Skip to content

Register chrome.downloads.onDeterminingFilename.addListener to get chance to specify filename. #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PassionZhao wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Register chrome.downloads.onDeterminingFilename.addListener to get chance to specify filename. #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions extension/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var testmode = false; //set to true to avoid path test
var testmode = true; //set to true to avoid path test
var minutebacks = false; //set to true to allow backs every minute for testing

var tiddlywikilocations = "tiddlywikilocations";
Expand Down Expand Up @@ -45,7 +45,17 @@ chrome.runtime.onMessage.addListener(function(msg, sender, sendResponse) {


function dodownload (msg,tiddlywikilocations){
var objUrl = URL.createObjectURL(new Blob([msg.txt], {type: 'text/html'}));
var objUrl = URL.createObjectURL(new Blob([msg.txt], {type: 'text/html'}));

console.log("id:" + chrome.runtime.id)

chrome.downloads.onDeterminingFilename.addListener(function SuggestFilename(item, suggest) {
if (item.byExtensionId && item.byExtensionId === chrome.runtime.id) {
suggest({filename: tiddlywikilocations+$["/"]+ msg.path, conflictAction: 'overwrite'});
chrome.downloads.onDeterminingFilename.removeListener(SuggestFilename);
}
});

chrome.downloads.download({
url: objUrl,
filename: tiddlywikilocations+$["/"]+ msg.path,
Expand Down Expand Up @@ -119,6 +129,7 @@ function dodownload (msg,tiddlywikilocations){
}
console.log("savetiddlersbg: background 3nd step");
// show the choose file dialogue when tw not under 'tiddlywikilocations'
// testmode=true
if (!msg.twdl) {
console.log("savetiddlersbg: not in "+tiddlywikilocations+" "+msg.path);
sendResponse({status:"failedloc",location:tiddlywikilocations});
Expand Down Expand Up @@ -206,6 +217,4 @@ function dodownload (msg,tiddlywikilocations){
}
});
}return true;
});


});