Skip to content

CI: Get to green - #79

Merged
brunofacca merged 16 commits into
brunofacca:masterfrom
olleolleolle:appraisals-update-bundler
Jan 6, 2026
Merged

CI: Get to green#79
brunofacca merged 16 commits into
brunofacca:masterfrom
olleolleolle:appraisals-update-bundler

Conversation

@olleolleolle

@olleolleolle olleolleolle commented Jan 1, 2026

Copy link
Copy Markdown
Contributor

This PR is a long quest to get to green in this repo.

The thing that was most broken was:

  • Appraisal not having added the ruby platform (so I added it)
  • RuboCop having old configuration (so I separated it into its own Lint CI job)
  • The gem currently does not support Rails 8.0 - the tests do produce output, but the expectations fail.
  • The gem currently does not supporting Rails 8.1 LogSubscriber new API

Learnings and notes

Appraisal offers calling commands on all the gemfiles at once: very practical. Example:

appraisal bundle update --bundler

@olleolleolle olleolleolle changed the title Gemfiles: use latest Bundler CI: Get to green Jan 1, 2026
@brunofacca

Copy link
Copy Markdown
Owner

Thank you very much for this big contribution!
This looks good to me in the sense that it's a big step in the right direction (3 Ruby/Rails version combinations are now passing). Would you like me to merge as is (after the git conflicts are fixed) or are you planning on pushing any additional commits?

@olleolleolle

olleolleolle commented Jan 6, 2026

Copy link
Copy Markdown
Contributor Author

@brunofacca Um, I'll fix the conflicts (EDIT: ✅ now done).

I intend no further changes to this PR.

@olleolleolle
olleolleolle force-pushed the appraisals-update-bundler branch from 06d4ee2 to 35b9bc3 Compare January 6, 2026 09:09
@brunofacca
brunofacca merged commit 09855cc into brunofacca:master Jan 6, 2026
4 of 11 checks passed
@brunofacca

Copy link
Copy Markdown
Owner

Thank you again, we finally have a working CI after Travis discontinued their free tier!

@olleolleolle
olleolleolle deleted the appraisals-update-bundler branch January 7, 2026 08:01
@olleolleolle olleolleolle mentioned this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants