Avoid NegativeArraySizeException in ProxyLeakTask on short stack traces#2406
Open
vasiliy-mikhailov wants to merge 1 commit into
Open
Conversation
ProxyLeakTask.run() trims the first 5 (HikariCP-internal) frames from the captured stack trace via new StackTraceElement[stackTrace.length - 5]. When the leak-detection exception has fewer than 5 frames (for example when stack traces are disabled), length - 5 is negative and the scheduled leak-detection task throws NegativeArraySizeException instead of logging the leak. Clamp the trimmed length to zero and skip the copy when empty. Adds a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProxyLeakTask.run()trims the first 5 (HikariCP-internal) frames from the captured stack trace:When the leak-detection exception has fewer than 5 frames (for example when stack traces are disabled via
-XX:-StackTraceInThrowable, or in minimal stacks),stackTrace.length - 5is negative and the scheduled leak-detection task throwsNegativeArraySizeExceptioninstead of logging the leak warning.This clamps the trimmed length to zero (and skips the copy when empty). Includes a regression test.