Fail fast for closed pool health checks#2403
Open
ittaigolde wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2325.
The Dropwizard connectivity health check keeps a direct
HikariPoolreference. AfterHikariDataSource.close(), calling the health check still went throughpool.getConnection(checkTimeoutMs), so it waited for the configured health-check timeout even though the pool was already shut down and could never provide a connection.This change makes
ConnectivityHealthCheckreturn an unhealthy result immediately when the pool is already shut down.Reproduction before the fix:
CodahaleMetricsTest#testConnectivityHealthCheckFailsFastAfterShutdownwaited 765ms withconnectivityCheckTimeoutMs=750.Verification after the fix:
mvn -Djacoco.skip=true -Dtest=CodahaleMetricsTest testmvn -Djacoco.skip=true -Dtest=CodahaleMetricsTest test