Skip to content

Add (static) labels to metrics #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ntavares wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add (static) labels to metrics #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions prometheus_es_exporter/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def collect(self):


def run_query(es_client, query_name, indices, query,
timeout, on_error, on_missing):
timeout, on_error, on_missing, static_labels):

try:
response = es_client.search(index=indices, body=query, request_timeout=timeout)
Expand Down Expand Up @@ -230,6 +230,8 @@ def run_query(es_client, query_name, indices, query,
# metrics, but all zero values.
metric_dict = merge_metric_dicts(old_metric_dict, {},
zero_missing=True)
for label, value in static_labels.items():
metric_dict[label] = value

METRICS_BY_QUERY[query_name] = metric_dict

Expand Down Expand Up @@ -602,18 +604,24 @@ def cli(**options):
fallback='drop')
on_missing = config.getenum(section, 'QueryOnMissing',
fallback='drop')
opt_static_labels = config.get(section, 'StaticLabels',
fallback='')
static_labels = {}
for kv in opt_static_labels.split(','):
k, v, _ = kv.split('=')
static_labels[k] = v

queries[query_name] = (interval, timeout, indices, query,
on_error, on_missing)
on_error, on_missing, static_labels)

scheduler = sched.scheduler()

if queries:
for query_name, (interval, timeout, indices, query,
on_error, on_missing) in queries.items():
on_error, on_missing, static_labels) in queries.items():
schedule_job(scheduler, executor, interval,
run_query, es_client, query_name, indices, query,
timeout, on_error, on_missing)
timeout, on_error, on_missing, static_labels)
else:
log.error('No queries found in config file(s)')
return
Expand Down