Story 2422: Sign In Webpage Integration#2487
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
herzog0
left a comment
There was a problem hiding this comment.
Besides the redirect bug, could we also strip out all legacy stuff?
That means:
- Removing the
V3LoginViewfromviews.py; - Removing
context["login_url"] = reverse_lazy("v3-login")fromcore/mixins.py; - Removing the path
v3/accounts/login/fromconfig/v3_urls.py;
| class CustomLoginView(LoginView): | ||
| class CustomLoginView(V3AuthContextMixin, LoginView): | ||
| v3_template_name = "v3/accounts/login.html" | ||
|
|
There was a problem hiding this comment.
ae386f0 to
0b24e9a
Compare

Issue: #2422
Summary & Context
Implements the V3 version of the sign in page. Note that this branches off of: #2482 to take advantage of the changes made to auth pages in general.
Changes
Please list any potential risks or areas that need extra attention during review/testing
There is no great way to test the social sign in locally, since it relies on Oauth that is not set up for development.
Screenshots
Self-review Checklist
Frontend