Skip to content

Story 2422: Sign In Webpage Integration#2487

Open
jlchilders11 wants to merge 1 commit into
boostorg:jc/webpage-integration-sign-upfrom
jlchilders11:jc/webpage-integration-sign-in
Open

Story 2422: Sign In Webpage Integration#2487
jlchilders11 wants to merge 1 commit into
boostorg:jc/webpage-integration-sign-upfrom
jlchilders11:jc/webpage-integration-sign-in

Conversation

@jlchilders11

Copy link
Copy Markdown
Collaborator

Issue: #2422

Summary & Context

Implements the V3 version of the sign in page. Note that this branches off of: #2482 to take advantage of the changes made to auth pages in general.

Changes

  • Changes the template for the sign in page to use the V3 version.
  • Implements the social sign in links

‼️ Risks & Considerations ‼️

Please list any potential risks or areas that need extra attention during review/testing
There is no great way to test the social sign in locally, since it relies on Oauth that is not set up for development.

Screenshots

image

Self-review Checklist

  • Link this PR to the related GitHub Project ticket

Frontend

  • UI implementation matches Figma design
  • Tested in light and dark mode
  • Responsive / mobile verified
  • Accessibility checked (keyboard navigation, etc.)
  • Ensure design tokens are used for colors, spacing, typography, etc. – No hardcoded values
  • Test without JavaScript (if applicable)
  • No console errors or warnings

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 76a9e7eb-8403-45d1-8eb7-b8908eecbe01

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jlchilders11 jlchilders11 linked an issue Jun 11, 2026 that may be closed by this pull request
@julioest julioest self-requested a review June 11, 2026 17:38
@herzog0 herzog0 self-requested a review June 12, 2026 14:34

@herzog0 herzog0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the redirect bug, could we also strip out all legacy stuff?
That means:

  1. Removing the V3LoginView from views.py;
  2. Removing context["login_url"] = reverse_lazy("v3-login") from core/mixins.py;
  3. Removing the path v3/accounts/login/ from config/v3_urls.py;

Comment thread users/views.py
class CustomLoginView(LoginView):
class CustomLoginView(V3AuthContextMixin, LoginView):
v3_template_name = "v3/accounts/login.html"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the V3Mixing dispatches, it sets _v3_active = False for POST requests, so it falls through the legacy login page. That means, if an error occurs during login, we're redirected to the legacy page.
To reproduce:

  • Go to login page;
  • Insert an email;
  • Insert a wrong password and submit;
Image

@jlchilders11 jlchilders11 force-pushed the jc/webpage-integration-sign-in branch from ae386f0 to 0b24e9a Compare June 12, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webpage Integration: Sign In

2 participants