-
Notifications
You must be signed in to change notification settings - Fork 26
Story 2451: AI-Assisted Description for Link Posts type #2477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from 39 commits
904fde2
d19ae6c
0872d78
b5b8af0
49ac1a1
0218751
9c5880b
a472baa
ba7c8c7
428ea95
4be282e
d6d1f5d
ca2d0d1
7921c7b
59b5547
33d080a
0ee4ca6
7d44244
3e25023
51d552c
ec3958e
aa05dcc
02f22de
ef53389
2c99bf3
74b877d
d024ef8
3b38304
671b8a7
b8a63a4
ea165c4
1bbccec
a039e95
c2007f6
a3ebdd1
3dd05d6
cce6fa3
2aebc6b
9729724
c3979af
307a692
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -290,7 +290,7 @@ def get_stats(self, base_uri: str = None): | |
| # NOTE TO FUTURE DEVS: remember to account for the fact that a report | ||
| # configuration may not match with a real version in frequent cases where | ||
| # reports are generated before the release version has been created. | ||
| (report_before_release, prior_version, version) = determine_versions( | ||
| report_before_release, prior_version, version = determine_versions( | ||
| report_configuration.version | ||
| ) | ||
|
|
||
|
|
@@ -368,21 +368,19 @@ def core_batchable(x): | |
| git_graph_data = get_git_graph_data(prior_version, version) | ||
| download = get_download_links(version, base_uri) | ||
| ### completed task handling ### | ||
| (mailinglist_contributor_release_count, mailinglist_contributor_new_count) = ( | ||
| mailinglist_contributor_release_count, mailinglist_contributor_new_count = ( | ||
| mailing_list_contributors_task.get() | ||
| ) | ||
| (mailinglist_post_stats, total_mailinglist_count) = ( | ||
| mailing_list_stats_task.get() | ||
| ) | ||
| (commit_contributors_release_count, commit_contributors_new_count) = ( | ||
| mailinglist_post_stats, total_mailinglist_count = mailing_list_stats_task.get() | ||
| commit_contributors_release_count, commit_contributors_new_count = ( | ||
| commit_contributors_task.get() | ||
| ) | ||
| ( | ||
| mailinglist_words, | ||
| mailinglist_wordcloud_base64, | ||
| mailinglist_wordcloud_top_words, | ||
| ) = mailinglist_wordcloud_task.get() | ||
| (search_wordcloud_base64, search_wordcloud_top_words, search_stats) = ( | ||
| search_wordcloud_base64, search_wordcloud_top_words, search_stats = ( | ||
| search_wordcloud_task.get() | ||
| ) | ||
| global_contributors_new_count = new_contributors_count_task.get() | ||
|
|
@@ -441,7 +439,7 @@ def generate_context( | |
| # NOTE TO FUTURE DEVS: remember to account for the fact that a report | ||
| # configuration may not match with a real version in frequent cases where | ||
| # reports are generated before the release version has been created. | ||
| (report_before_release, prior_version, version) = determine_versions( | ||
| report_before_release, prior_version, version = determine_versions( | ||
| report_configuration.version | ||
| ) | ||
|
Comment on lines
+442
to
444
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unused value from
🧰 Tools🪛 Ruff (0.15.15)[warning] 442-442: Unpacked variable Prefix it with an underscore or any other dummy variable pattern (RUF059) 🤖 Prompt for AI AgentsSource: Linters/SAST tools
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. out of scope for this PR. They're pre-existing lint, unrelated to anything changed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Understood, Would you like me to open a follow-up GitHub issue to track fixing the unused (´• ω •`) 🐇 |
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,6 @@ | |
|
|
||
| from config.celery import app | ||
|
|
||
|
|
||
| logger = structlog.getLogger(__name__) | ||
|
|
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,6 @@ | |
| from django.contrib.auth import get_user_model | ||
| from django.db.models import Q | ||
|
|
||
|
|
||
| User = get_user_model() | ||
|
|
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| NEWS_APPROVAL_SALT = "news-approval" | ||
| MAGIC_LINK_EXPIRATION = 3600 * 24 # 24h | ||
| CONTENT_SUMMARIZATION_THRESHOLD = 1000 # characters | ||
| # Target length for the AI-generated Description. Kept under the 1000-char field | ||
| # cap so the model has some leeway and the result fits without truncation. | ||
| DESCRIPTION_SUMMARY_MAX_LENGTH = 900 # characters |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused unpacked value in task result handling.
mailinglist_wordsis unpacked but never used. Rename it to_mailinglist_words(or_) to make intent explicit and satisfy lint rules.🧰 Tools
🪛 Ruff (0.15.15)
[warning] 379-379: Unpacked variable
mailinglist_wordsis never usedPrefix it with an underscore or any other dummy variable pattern
(RUF059)
🤖 Prompt for AI Agents
Source: Linters/SAST tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of scope for this PR. They're pre-existing lint, unrelated to anything changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, thanks for the context. Would you like me to open a follow-up GitHub issue to track the cleanup of the unused
mailinglist_wordsvariable so it doesn't get lost?(ᴖ̥̥̥̥ ‸ ᴖ̥̥̥̥)