[PM-35442] Json user repository not updating - #268
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## km/pm-35442-key-connector-not-updating-key #268 +/- ##
==============================================================================
+ Coverage 37.73% 42.98% +5.24%
==============================================================================
Files 49 49
Lines 1823 1833 +10
Branches 99 99
==============================================================================
+ Hits 688 788 +100
+ Misses 1100 1010 -90
Partials 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thomas-Avery
suggested changes
May 26, 2026
Thomas-Avery
left a comment
Thomas-Avery
left a comment
There was a problem hiding this comment.
Nice addition on the integration tests.
mzieniukbw
marked this pull request as draft
May 27, 2026 16:21
mzieniukbw
force-pushed
the
km/pm-35442-user-repository-json-bug
branch
from
May 27, 2026 16:22
026baa3 to
98cc46b
Compare
mzieniukbw
changed the base branch from
main
to
km/pm-35442-key-connector-not-updating-key
May 27, 2026 16:22
Contributor
Author
|
@Thomas-Avery To ease QA testing, i decided to cherry-pick the commits on top of |
mzieniukbw
marked this pull request as ready for review
May 27, 2026 16:23
|
Thomas-Avery
previously approved these changes
May 27, 2026
Base automatically changed from
km/pm-35442-key-connector-not-updating-key
to
main
June 4, 2026 11:59
mzieniukbw
enabled auto-merge (squash)
June 4, 2026 12:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-35442
📔 Objective
JSON file repository
UpdateAsyncandDeleteAsyncnot persisting changes.Root cause:
CreateAsyncstores records usingJsonUserKeyModel(string ID) butUpdateAsync/DeleteAsyncinherited from the base Repository class which passes aGuidtoReplaceOneAsync/DeleteOneAsync, which never matches.Added integration tests for all user key repository implementations: JSON file, EF (Sqlite, Microsoft Sql server, PostgreSQL, MySql, MariaDb), Mongo.
📸 Screenshots