[bitnami/redis] bugfix: honor custom labels on PVCs

[initharrington]

Description of the change

Custom labels supplied via master.persistence.labels, replica.persistence.labels, sentinel.persistence.labels, and commonLabels were silently dropped from rendered PVCs in volumeClaimTemplates. The templates used common.labels.matchLabels, which picks only app.kubernetes.io/name and app.kubernetes.io/instance out of the input — filtering every other user-supplied label.

Switched the three PVC templates to common.labels.standard, which merges custom labels with the standard set. This matches how every other non-selector labels: field in the chart is already rendered.

Two adjacent bugs fixed in the same change:

• The replica PVC template was reading .Values.master.persistence.labels instead of .Values.replica.persistence.labels — a copy-paste from the master template.
• The sentinel redis-data PVC ignored replica.persistence.labels entirely, even though it inherits every other field from replica.persistence.*.

Benefits

Custom labels on PVCs now work as documented in values.yaml. This unblocks label-selector-based tooling (Prometheus alert routing, cost allocation, ownership tags) that previously had no way to land labels on PVCs without manually patching them post-install. Important because volumeClaimTemplates are immutable after StatefulSet creation.

Possible drawbacks

PVCs will now carry the full set of standard labels (app.kubernetes.io/name, instance, managed-by, version, helm.sh/chart) plus user-supplied labels, where previously they only carried name and instance. Anyone with external selectors matching PVCs on the absence of those keys would be affected, but that would be an unusual setup.

Applicable issues

• fixes [bitnami/redis] Custom labels on PVCs are silently dropped — master.persistence.labels/replica.persistence.labels not honored #36536

Additional information

Validated by rendering each architecture (standalone, replication, sentinel) with custom *.persistence.labels + commonLabels and confirming the labels appear on the rendered PVCs. Also rendered with defaults to confirm the no-custom-labels case still produces the expected standard label set. helm lint passes.

Checklist

• Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
• Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
• [X Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
• All commits signed off and in agreement of Developer Certificate of Origin (DCO)

[juan131]

This would open the door for introducing mutable labels (e.g. those depending on chart version) that would break upgrading in the future given these fields are considered inmutable by K8s

[github-actions]

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

[github-actions]

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.