ci: install librsvg2-bin and imagemagick for test each commit#328
Open
kwsantiago wants to merge 1 commit into
Open
ci: install librsvg2-bin and imagemagick for test each commit#328kwsantiago wants to merge 1 commit into
kwsantiago wants to merge 1 commit into
Conversation
|
ACK c198e9b I reviewed the change to ci.yml and found it contained exactly what was required to resolve the issue. |
Ari4ka
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test each commitjob configures with-DBUILD_GUI=ON, but does not install the icon-rendering tools thatBUILD_GUIrequires, so CMake aborts during configure:CMakeLists.txtrequires both tools when building the GUI on non-Darwin:test each commitis the only job missing them. Every other CI path already installs them:ci/test/00_setup_env.sh,ci/test/00_setup_env_mac_cross.sh,ci/test/00_setup_env_native_centos.sh, and the macOSbrew install ... librsvgstep in this same workflow.The job runs only on pull requests with more than one commit, which is why it does not fail on every PR.
Example failure: https://github.com/bitcoinknots/bitcoin/actions/runs/28277646974/job/85830663679
Verification
In a clean
ubuntu:24.04container, installing the job's current package list leaves all three binaries absent:Running the job's exact cmake configure line then reproduces the CI error verbatim:
After adding
librsvg2-binandimagemagick,rsvg-convertandconvertresolve, and the same configure completes:imagemagickis included becausefind_program(IMAGEMAGICK_CONVERT NAMES magick convert REQUIRED)is reached immediately after thersvg-convertcheck, and it is likewise absent both from the job's package list and from theubuntu-24.04runner image's apt manifest.Refs #327.