Inform user of upcoming RDTS softfork and lack of enforcement by this software#289
Closed
luke-jr wants to merge 14 commits into
Closed
Inform user of upcoming RDTS softfork and lack of enforcement by this software#289luke-jr wants to merge 14 commits into
luke-jr wants to merge 14 commits into
Conversation
luke-jr
force-pushed
the
rdts_not_enforced_prompt
branch
from
March 20, 2026 19:50
7cb0b65 to
e677c59
Compare
luke-jr
force-pushed
the
rdts_not_enforced_prompt
branch
from
March 20, 2026 20:06
e677c59 to
5dd14d6
Compare
kwsantiago
approved these changes
Mar 20, 2026
kwsantiago
left a comment
kwsantiago
left a comment
There was a problem hiding this comment.
utACK 5dd14d685b48d17424a32ac21623e70efaa10582
luke-jr
force-pushed
the
rdts_not_enforced_prompt
branch
3 times, most recently
from
March 27, 2026 15:20
71283f7 to
34c694b
Compare
luke-jr
force-pushed
the
rdts_not_enforced_prompt
branch
from
May 1, 2026 16:55
34c694b to
1f4ad48
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
luke-jr
changed the title
luke-jr
force-pushed
the
rdts_not_enforced_prompt
branch
5 times, most recently
from
May 4, 2026 05:10
c478d68 to
d4afc5b
Compare
…to return true for ThreadSafeQuestion
luke-jr
force-pushed
the
rdts_not_enforced_prompt
branch
from
May 7, 2026 18:20
d4afc5b to
c2a6a67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #256 for a final pre-RDTS release
By default, informs the user of the upcoming softfork and warns that this version doesn't enforce it, but still runs (unless the GUI user clicks Abort).
If the user has already upgraded to RDTS previously, they are prompted to remove
consensusrules=rdtsfrom their config file(s), and the software does not start.If there's
consensusrulesset other than "rdts", simply error and fail to start. (I'll import this to #256 also)