GUI/Intro: Skip intro dialog when -blocksdir is manually passed#948
Open
diegoviola wants to merge 1 commit into
Open
GUI/Intro: Skip intro dialog when -blocksdir is manually passed#948diegoviola wants to merge 1 commit into
diegoviola wants to merge 1 commit into
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline and AI policy for information on the review process.
If your review is incorrectly listed, please copy-paste |
pablomartin4btc
left a comment
pablomartin4btc
left a comment
Contributor
There was a problem hiding this comment.
Concept ACK
The actual problem in #946 is the intro dialog's prune suggestion (only shown the first time bitcoin-qt runs) — FreespaceChecker checks datadir's free space but the prune trigger uses the full blockchain + chainstate threshold (~880 GB), incorrectly suggesting prune when -blocksdir is set since only ~14 GB of chainstate goes to datadir. Skipping the dialog avoids the wrong suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #946