Add Brazilian Portuguese (pt_BR) translation for the about page#1260
Add Brazilian Portuguese (pt_BR) translation for the about page#1260devdavidejesus wants to merge 6 commits into
Conversation
Add pt_BR language scaffolding (languages.yml, translations.yml, navigation.yml) and translate the about page. Untranslated navigation entries point to /en/ following the existing es/ja pattern.
|
Just checking if there’s any feedback on this. @achow101 |
|
Hi @devdavidejesus, thanks for the initiative. I think this might be a bit stuck, because none of the people subscribed to this repository read Portuguese. I have pinged a couple Bitcoin Core contributors that do, to ask whether they could take a look. Perhaps if it had some review from some Bitcoin Core regulars, it would gain some traction. |
Thanks, @murchandamus. I appreciate you reaching out to other contributors. I'm available to help the Bitcoin Core team with the Brazilian Portuguese (pt_BR) translation. |
| #redirect_from: | ||
| # - /zh_TW/about/ | ||
| # - /en/team/ |
There was a problem hiding this comment.
I think these comments might be functional redirects and in that case should only be on the English page.
| #redirect_from: | |
| # - /zh_TW/about/ | |
| # - /en/team/ |
The second one would make sense if there is a link to a team page somewhere, but I assume that it handles a page that was removed in the past and redirects potential existing links around the internet to the about page.
Per review, redirect_from entries are functional redirects that belong only on the English page, so they are removed from the translation.
|
Good catch, thanks. I’ve just removed them in the latest push. I had mirrored the es/about page, which has the same lines commented out, so the same cleanup applies there too. |
|
Concept ACK. Thanks for adding this. While testing locally, I found that the locale scaffolding is incomplete: The patch below adds the same index, RSS, and feed source files used for Japanese and Spanish in #419 and #814. With these files, Jekyll builds and HTML-Proofer passes locally. patchdiff --git a/_posts/pt_BR/pages/2016-01-01-index.md b/_posts/pt_BR/pages/2016-01-01-index.md
new file mode 100644
--- /dev/null
+++ b/_posts/pt_BR/pages/2016-01-01-index.md
@@ -0,0 +1,13 @@
+---
+layout: home
+type: pages
+lang: pt_BR
+title: Bitcoin
+name: index
+permalink: /pt_BR/
+version: 2
+tags: [bitcoin, bitcoin core]
+translated: true
+---
+
+Bitcoin
diff --git a/_posts/pt_BR/pages/2016-03-21-rss.md b/_posts/pt_BR/pages/2016-03-21-rss.md
new file mode 100644
--- /dev/null
+++ b/_posts/pt_BR/pages/2016-03-21-rss.md
@@ -0,0 +1,10 @@
+---
+title: RSS Feeds
+name: rss
+permalink: /pt_BR/rss/
+type: pages
+layout: page
+lang: pt_BR
+version: 1
+---
+{% include pages/rss.html %}
diff --git a/assets/feeds/feed-pt_BR.xml b/assets/feeds/feed-pt_BR.xml
new file mode 100644
--- /dev/null
+++ b/assets/feeds/feed-pt_BR.xml
@@ -0,0 +1,6 @@
+---
+layout: feed
+sitemap: false
+lang: pt_BR
+permalink: /pt_BR/feed.xml
+---
diff --git a/assets/meeting_rss/rss-pt_BR.xml b/assets/meeting_rss/rss-pt_BR.xml
new file mode 100644
--- /dev/null
+++ b/assets/meeting_rss/rss-pt_BR.xml
@@ -0,0 +1,7 @@
+---
+layout: meetingrss
+type: rss
+sitemap: false
+lang: pt_BR
+permalink: /pt_BR/meetingrss.xml
+---
diff --git a/assets/rss/rss-pt_BR.xml b/assets/rss/rss-pt_BR.xml
new file mode 100644
--- /dev/null
+++ b/assets/rss/rss-pt_BR.xml
@@ -0,0 +1,7 @@
+---
+layout: rss
+type: rss
+sitemap: false
+lang: pt_BR
+permalink: /pt_BR/rss.xml
+--- |
Per review, the pt_BR locale referenced routes that did not exist. Adds the same index, RSS page and feed source files used for Japanese and Spanish, so that /pt_BR/, /pt_BR/rss/ and the feed routes resolve.
Thanks for testing locally and for the patch, applied in the latest push. |
Co-authored-by: Bruno Garcia <brunoely.gc@gmail.com>
Co-authored-by: Bruno Garcia <brunoely.gc@gmail.com>
|
Thanks @brunoerg, both applied. "Incorporar" and "consenso" read better here. |
'Curadoria' implies editorial authority, while the original describes a deliberately humble, housekeeping role.
|
Also went over the text once more and changed "papel de curadoria" to "papel de manutenção", closer to the "janitorial role" in the original. |
4 participants
This adds Brazilian Portuguese (pt_BR) as a new language, starting with the about page.
Changes:
This is intended as the first step of an incremental pt_BR effort. I plan to follow up with additional static pages (contribute, contact, meetings, lifecycle) one at a time. Feedback on the translation and structure is welcome.