Bump Ruby to 3.3.8 and Debian to Trixie#1246
Conversation
You can test changes using https://github.com/bitcoin-core/bitcoincore.org/blob/master/contrib/devtools/README.md#dockerfile, which should work fine on macOS. |
|
The sass warning reveals a bigger can of worms: we're relying on LibSass which has been abandoned in favor of Dart Sass. So I dropped 34afa34. The warnings aren't too bad because they mostly get suppressed:
A real fix would involve installing Dart Sass on CI, brining the commit back and then decide whether we want to make the same (trivial) changes to the vendored code. |
|
These sass warnings predate this PR, so I'll track them separately: #1249 |
|
Just saw #1223, which is probably better than my second commit. Marking this draft. |
|
Temporarily pushed the commits from #1223 here to see if those still work after the Ruby / Debian update. |
|
The debian only CI job is setup to match the current build infrastructure to let us know if a change may break when the website is rebuilt. It should only be changed when the infra is changed. |
|
@achow101 I know that, this PR implies changing the infrastructure from Debian to Trixie. If CI passes, that change should be safe. Well, at least not obviously broken. |
Debian trixie ships ruby3.3 3.3.8-2. Use Ruby 3.3.8 for local development, the GitHub Actions Ruby container, and the devtools Docker image. Add base64 and csv as explicit dependencies to avoid warnings.
|
Rebased after #1223 landed and slightly clarified the PR description. |
3 participants
The current Ruby version is end-of-life and doesn't work on modern macOS, making it hard to test changes locally. The latter can be worked around, see #1246 (comment).
Debian Bookworm is still in LTS, but so is the newer Trixie. Hopefully the backend can be updated to that.
The latest patch version is 3.3.11, but a backend upgrade to Trixie ships Ruby 3.3.8. The 3.3.x branch is still maintained, until March 2027.
I lightly tested the site locally.