31.0: add RPC docs - #1245
Merged
Merged
Conversation
polespinasa
approved these changes
May 11, 2026
polespinasa
left a comment
Member
There was a problem hiding this comment.
ACK cd948c6
I did ran the script myself and got the same result
$ git log --oneline -n2
717a951 (HEAD -> master) generated by me
667555a (upstream/master, origin/master, origin/HEAD) Merge bitcoin-core/bitcoincore.org#1244: doc: Add my key to contacts
sliv3r@sliv3r-tuxedo:~/Documentos/Projectes/BitcoinCore/bitcoincore.org/contrib/doc-gen$ git checkout pr-1245
Switched to branch 'pr-1245'
sliv3r@sliv3r-tuxedo:~/Documentos/Projectes/BitcoinCore/bitcoincore.org/contrib/doc-gen$ git cherry-pick 717a951
On branch pr-1245
You are currently cherry-picking commit 717a951.
(all conflicts fixed: run "git cherry-pick --continue")
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)
nothing to commit, working tree clean
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:
git commit --allow-empty
Otherwise, please use 'git cherry-pick --skip'
Member
|
cc @stickies-v |
Open
stickies-v
approved these changes
May 11, 2026
stickies-v
left a comment
Contributor
There was a problem hiding this comment.
ACK cd948c6
I'm getting the same diff, and reviewing the diff with v30.0 I couldn't see any obvious bugs.
Member
Author
|
Looks OK on production too: https://bitcoincore.org/en/doc/31.0.0/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1187 for the previous doc update.