feat(footer): rebuild and optimize footer UX#1171
Open
ritorhymes wants to merge 1 commit into
Open
Conversation
- add X social icon asset and accessible X button - use semantic <footer> element - refactor HTML/SCSS to Flexbox for spacing and alignment - link Bitcoin Core logo to localized home route - improve a11y for links - remove clearfix and modernize legacy styling
ritorhymes
force-pushed
the
feat/footer-optimize
branch
from
September 15, 2025 14:36
13bd8d4 to
bb8d908
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Author
|
@m3dwards just a friendly nudge, do you think we could get a review for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuild and modernize the footer to improve UX and accessibility while preserving the original content and general visual intent.
There were design issues with the spacing and alignment of the footer elements, and opportunities to improve the UX and accessibility.
Issues:
Scope Edited:
footer.htmlandpage.scss, added one image assetx.pngOverview of Changes
<footer>.clearfixand modernize legacy styling.Layout details
Using flexbox and other centering tools:
New button-styled social media link
The "X" character used originally to link to the social media account felt out of place in the layout, it looked like a free-floating typo, and it didn't provide good context for users and assistive technologies. Since Bitcoin Core is a world-leading client and there is only one social media account representing it, I decided to treat the link element as a first-class citizen by styling it like a button that includes:
Before and After Images
Desktop Before
Desktop After
Mobile Before @ 482 screen width
Mobile After @ 482 screen width
Mobile Before @ 400 screen width
Mobile After @ 400 screen width
Testing
I've tested a local build running on the following browsers with both the desktop and mobile app versions:
Behaviors appear consistent across browsers tested. Feel free to verify on other browsers also.