Skip to content

use correct picture#580

Merged
sugaarK merged 1 commit into
betaflight:masterfrom
sugaarK:fix-rate-pic
May 2, 2026
Merged

use correct picture#580
sugaarK merged 1 commit into
betaflight:masterfrom
sugaarK:fix-rate-pic

Conversation

@sugaarK

@sugaarK sugaarK commented May 2, 2026

Copy link
Copy Markdown
Member

linked picture didn't match the rates

Summary by CodeRabbit

  • Documentation
    • Updated preset description with a refreshed screenshot reference.

@sugaarK sugaarK self-assigned this May 2, 2026
@coderabbitai

coderabbitai Bot commented May 2, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Updated the screenshot image URL and metadata in a Betaflight preset configuration file, replacing a GitHub user-images link dated 2023-03-02 with a newer user-attachments link dated 2026-05-02 in the DESCRIPTION field.

Changes

Preset Metadata Update

Layer / File(s) Summary
Screenshot Reference
presets/4.3/rates/SugarK_whoop.txt
#$ DESCRIPTION: field updated with new GitHub screenshot image URL and timestamp (2026-05-02), replacing the outdated 2023-03-02 link.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • KarateBrot
  • limonspb
  • blckmn

Poem

🐰 A screenshot grows old, its link turns to dust,
So we swap it for fresh with a timestamp we trust,
From twenty-three to twenty-six, the image renewed,
User-attachments now shine where old images sued!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is extremely minimal and does not follow the repository's template structure; it lacks required context about the change. Expand the description to explain why the old image URL was incorrect, what the new image URL is, and ensure compliance with repository guidelines.
Title check ❓ Inconclusive The title 'use correct picture' is vague and lacks specificity about what picture was corrected or which preset file was affected. Use a more descriptive title that identifies the specific preset or file being updated, such as 'Update SugarK_whoop preset screenshot link'
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sugaarK sugaarK assigned haslinghuis and unassigned haslinghuis May 2, 2026
@sugaarK sugaarK requested a review from haslinghuis May 2, 2026 13:17
@github-actions

github-actions Bot commented May 2, 2026

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
presets/4.3/rates/SugarK_whoop.txt (1)

11-12: ⚡ Quick win

Avoid an empty #$ DESCRIPTION: directive (potential parser/rendering edge-case).

Lines 11–12 create an empty #$ DESCRIPTION: line followed immediately by the image #$ DESCRIPTION: line. Depending on how the preset metadata is parsed/rendered, this can result in an extra blank line, overwritten description text, or inconsistent formatting.

Suggested (optional) adjustment
-#$ DESCRIPTION:
 #$ DESCRIPTION: <img width="400" alt="Screenshot 2026-05-02 at 11 11 48 pm" src="https://github.com/user-attachments/assets/47b0b75f-eea3-4b76-928b-425f4cb1c928" />
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@presets/4.3/rates/SugarK_whoop.txt` around lines 11 - 12, The file contains
an empty `#$ DESCRIPTION:` directive followed immediately by another `#$
DESCRIPTION:` containing the image; remove the empty `#$ DESCRIPTION:` or merge
the image into the first description to avoid an empty metadata entry;
specifically edit the `#$ DESCRIPTION:` directives in the preset (the duplicate
DESCRIPTION lines) so there is only one `#$ DESCRIPTION:` line that includes the
image/alt text, ensuring no blank DESCRIPTION directive remains.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@presets/4.3/rates/SugarK_whoop.txt`:
- Line 12: The embedded image reference on the DESCRIPTION line containing the
HTML img tag with the URL
"https://github.com/user-attachments/assets/47b0b75f-eea3-4b76-928b-425f4cb1c928"
is invalid; either replace that URL with a publicly accessible image URL
(ensuring it returns HTTP 200 and serves image content) or remove the entire img
tag from the line (the line beginning with "#$ DESCRIPTION: <img ... />") so the
preset gallery/renderer won't attempt to load a broken image.

---

Nitpick comments:
In `@presets/4.3/rates/SugarK_whoop.txt`:
- Around line 11-12: The file contains an empty `#$ DESCRIPTION:` directive
followed immediately by another `#$ DESCRIPTION:` containing the image; remove
the empty `#$ DESCRIPTION:` or merge the image into the first description to
avoid an empty metadata entry; specifically edit the `#$ DESCRIPTION:`
directives in the preset (the duplicate DESCRIPTION lines) so there is only one
`#$ DESCRIPTION:` line that includes the image/alt text, ensuring no blank
DESCRIPTION directive remains.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e83c08dc-dc06-4ae7-9ba3-199b9bdb5d33

📥 Commits

Reviewing files that changed from the base of the PR and between 61a8ec4 and a906370.

📒 Files selected for processing (1)
  • presets/4.3/rates/SugarK_whoop.txt

Comment thread presets/4.3/rates/SugarK_whoop.txt
haslinghuis
haslinghuis previously approved these changes May 2, 2026
@sugaarK

sugaarK commented May 2, 2026

Copy link
Copy Markdown
Member Author

does the html work for you @haslinghuis

@sugaarK sugaarK requested a review from haslinghuis May 2, 2026 13:35
@haslinghuis

haslinghuis commented May 2, 2026

Copy link
Copy Markdown
Member

@sugaarK - yes able to access URL because I'm an authorized GitHub user.

Might need something like

<img src="https://user-images.githubusercontent.com/2925027/265239785-62e444c4-2861-4691-beba-6125a9635954.png"/>

@sugaarK

sugaarK commented May 2, 2026

Copy link
Copy Markdown
Member Author

ahh let me check on my tablet... its not logged into git

@sugaarK sugaarK merged commit dccbde2 into betaflight:master May 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants