Skip to content

SidePanelItem selection is themed; PerformanceWidget is scrolled.#63

Open
albert-tomanek wants to merge 1 commit into
benapetr:masterfrom
albert-tomanek:master
Open

SidePanelItem selection is themed; PerformanceWidget is scrolled.#63
albert-tomanek wants to merge 1 commit into
benapetr:masterfrom
albert-tomanek:master

Conversation

@albert-tomanek

@albert-tomanek albert-tomanek commented Jun 18, 2026

Copy link
Copy Markdown

I changed the drawing code for SidePanelItem so that the background is drawn using the active theme and looks more native. For example on my Windows 7 theme:

image

I also wrapped the right pane inside the PerformanceWidget in a QScrollArea so that the app window can be resized below 600x800.

@albert-tomanek

Copy link
Copy Markdown
Author

Also is there any way to set the install prefix to something other than /opt/tux-manager/?

Comment thread src/mainwindow.cpp
#include "ui_mainwindow.h"
#include "configuration.h"

#include <QDebug>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add these includes? They even seem to repeat?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh whoops, I had a function in there to do some debugging but then i removed it. You can remove the includes

@benapetr

Copy link
Copy Markdown
Owner

Also is there any way to set the install prefix to something other than /opt/tux-manager/?

regarding this question - I am confused, are you talking about make install executed on the Makefile generated by qmake? Or any of those packaged versions?

I supposed you mean qmake, then it's in the .pro file at bottom

# Default rules for deployment.
qnx: target.path = /tmp/$${TARGET}/bin
else: unix:!android: target.path = /opt/$${TARGET}/bin
!isEmpty(target.path): INSTALLS += target

@benapetr

Copy link
Copy Markdown
Owner

Besides those extra includes in mainwindow I think this change looks ok (the coding style is inconsistent with rest of the codebase, but that's cosmetic, I can clean it up after merge).

I will run several tests on various distros I have installed and see if it doesn't break anything, then I will merge this.

@benapetr

Copy link
Copy Markdown
Owner

Unfortunately it doesn't seem to work even on first distro I tried - Ubuntu 24 with KDE.

Original version
image

Your version
image

Both "selected" frame and "hover" frame aren't working

@albert-tomanek

Copy link
Copy Markdown
Author

Ah, I didn't think to test it under other themes than mine. I'll try to make it work and then commit again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants