Add interactive screensaver & idle settings TUI (Setup → Config → Screensaver)#6086
Open
acidkill wants to merge 2 commits into
Open
Add interactive screensaver & idle settings TUI (Setup → Config → Screensaver)#6086acidkill wants to merge 2 commits into
acidkill wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4a1ec2379
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
When the screen action is 'Do nothing' but idle lock stays on, the idle timeout is the only value still driving the lock listener. The previous guard blocked editing it and hid it from the summary, leaving a fixed lock timeout (idle + stale lockdelay) with no way to change it. - choose_timeout: only block when no screen action AND lock is off - show the idle timeout whenever an action or the lock is active - add lock_timeout(): without a screen action the lock fires at idle itself (lockdelay only applies when an action precedes the lock), so the displayed/written lock time matches the editable timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add interactive screensaver & idle settings TUI (Setup → Config → Screensaver)
What
Adds
omarchy config screensaver— a small interactive TUI to configure idle behavior without hand-editinghypridle.conf:It is wired into the menu under Setup → Config → Screensaver, launched with
present_terminal— the same pattern already used for Direct Boot (omarchy-config-direct-boot).Why
Idle/screensaver/lock tuning currently means hand-editing
hypridle.conf(Setup → Config → Hypridle opens it in$EDITOR). This adds a friendly, discoverable editor for the common knobs, including two things that aren't obvious from raw config:How
bin/omarchy-config-screensaver(groupconfig, gum-based; mirrors the style ofomarchy-config-direct-boot).~/.config/hypr/hypridle.conf, taking a timestamped.bakbefore each write, then applies withomarchy-restart-hypridle.omarchy-refresh-config hypr/hypridle.conf.show_setup_config_menuinbin/omarchy-menu.Notes
config/hypr/hypridle.confis unchanged.configgroup already exists inGROUP_DESCRIPTIONS, so no group metadata change.omarchy-toggle-screensaver(thescreensaver-offflag) stays as a quick toggle.Testing
test/omarchy-cli-test.shpasses — metadata is valid and the command routes asomarchy config screensaver.hypridle.conffor every combination (screensaver / dpms / none × lock on/off) and confirmed round-trip parsing of the current settings, including the shipped default (screensaver, 150 s, lock on).Screenshots
Screensaver & idle settings TUI
