Ensure sudo works in cross-arch Docker image builds#6074
Open
axelfontaine wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a workaround so sudo works during cross-platform Docker image builds by adjusting the host’s binfmt/qemu configuration.
Changes:
- Introduces a migration script to patch
qemu-*-static.confand restartsystemd-binfmt. - Adds the same
sedpatch to the Docker install/config script.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| migrations/1780929365.sh | New migration to update binfmt qemu config and restart systemd-binfmt. |
| install/config/docker.sh | Applies the same binfmt config edit during Docker configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… docker-multiplatform-perms # Conflicts: # install/config/docker.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup
Run a cross-arch Docker image build with a
Dockerfilecontaining aUSERdirective andsudo:using the following command:
Before
It fails with:
After
It succeeds as expected and prints: