Surface xdg-open errors from open helper#6057
Open
shbernal wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the open() shell helper to change how xdg-open output and process behavior are handled.
Changes:
- Adjusts
xdg-openredirection inopen()to only drop stdout. - Removes background execution of
xdg-open.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| open() ( | ||
| xdg-open "$@" >/dev/null 2>&1 & | ||
| xdg-open "$@" >/dev/null & |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openshell helper surfacexdg-openstderr in the terminal/dev/nullso command output stays quietxdg-openbackgrounded in the subshell to preserve the non-blocking behavior and avoid job-control noiseCloses #6056
Testing
bash -n default/bash/aliasesgit diff --checkxdg-openconfirmed stderr is visible while stdout stays out of pipelines