Skip to content

fix: fetch injected provider from window.top first#67

Merged
fan-zhang-sv merged 2 commits into
masterfrom
felix/injected-window-top
Jul 28, 2025
Merged

fix: fetch injected provider from window.top first#67
fan-zhang-sv merged 2 commits into
masterfrom
felix/injected-window-top

Conversation

@fan-zhang-sv

Copy link
Copy Markdown
Collaborator

Summary

cherry picking this coinbase/coinbase-wallet-sdk#1696

How did you test your changes?

@cb-heimdall

cb-heimdall commented Jul 25, 2025

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@spencerstock spencerstock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary for apps who have integrated the account-sdk and want to access the right provider in Coinbase Wallet App/The Base App

@fan-zhang-sv
fan-zhang-sv merged commit d2f4f0c into master Jul 28, 2025
8 checks passed
@fan-zhang-sv
fan-zhang-sv deleted the felix/injected-window-top branch July 28, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants