GPU support by adding CuParticles#80
Draft
baggepinnen wants to merge 7 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #80 +/- ##
==========================================
- Coverage 94.27% 93.73% -0.54%
==========================================
Files 18 19 +1
Lines 891 990 +99
==========================================
+ Hits 840 928 +88
- Misses 51 62 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a type CuParticles that works as regular Particles but is backed by a CuArray. Expect in the range of 5-7x speedup over Particles if the sample size is 1e5 - 1e7.
EDIT 2021-04-22: For complex functions, the benefit of
CuParticlesmay appear already above 1e3 particles.Future memory-management improvements to the GPU ecosystem is likely to improve upon this number.