Skip to content

Activate .NET code analysis#48

Merged
Regenhardt merged 19 commits into
bagetter:mainfrom
Regenhardt:feature/code-analysis
Jan 31, 2024
Merged

Activate .NET code analysis#48
Regenhardt merged 19 commits into
bagetter:mainfrom
Regenhardt:feature/code-analysis

Conversation

@Regenhardt

Copy link
Copy Markdown

Taken from the open BaGet PR loic-sharma#784

Comment thread src/Directory.Build.props
@FroggieFrog

Copy link
Copy Markdown

According to the build workflow, there is still one issue left:
grafik

@FroggieFrog

Copy link
Copy Markdown

Maybe you can integrate 2 more changes from PR #46 (then #46 is superfluous and can be closed)

  1. in src/BaGetter.Core/Entities/Converters/StringArrayToJsonConverter.cs: line 14 v => (!string.IsNullOrEmpty(v)) ? JsonConvert.DeserializeObject<string[]>(v) : Array.Empty<string>())
  2. in tests/BaGetter.Tests/HostIntegrationTests.cs: line 65 .CreateHostBuilder(Array.Empty<string>())

@FroggieFrog FroggieFrog mentioned this pull request Jan 31, 2024
@seriouz

seriouz commented Jan 31, 2024

Copy link
Copy Markdown

@Regenhardt Can you merge?

@Regenhardt Regenhardt merged commit 77fef8d into bagetter:main Jan 31, 2024
@Regenhardt Regenhardt deleted the feature/code-analysis branch February 16, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants