Skip to content

fix: update request to return raw data instead of encoded text #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hudcap wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: update request to return raw data instead of encoded text #421

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84e595e
fix: update request to return raw data instead of encoded text
hudcap Jun 7, 2026
2deb763
fix tab.request test to compare to original bytes
hudcap Jun 7, 2026
b609a0f
fix comments
hudcap Jun 7, 2026
1023bcd
parallelize content reads
hudcap Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pydoll/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,8 @@ class Scripts:

// Extract cookies from set-cookie header
const cookies = document.cookie;
const responseClone = response.clone();
const content = await responseClone.arrayBuffer();
let text = await response.text();
const possiblePrefixes = [")]}}'\\n", ")]}}'\\n", ")]}}\\n"];
for (let prefix of possiblePrefixes) {{
Expand All @@ -260,7 +262,7 @@ class Scripts:
break;
}}
}}
let content, jsonData;
let jsonData;
const contentType = response.headers.get('content-type') || '';

if (contentType.includes('application/json')) {{
Expand All @@ -271,10 +273,8 @@ class Scripts:
jsonData = null;
// Keep original text if parsing fails
}}
content = new TextEncoder().encode(text).buffer;
}} else {{
// For non-JSON, keep original text handling
content = new TextEncoder().encode(text).buffer;
jsonData = null;
}}

Expand Down
Loading